Improvements to the Grafana LGTM dashboards #45747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview 32144de has been successfully built and deployed to https://quarkus-pr-main-45747-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
brunobat
requested changes
Jan 21, 2025
...lity-devservices/common/src/main/java/io/quarkus/observability/common/config/LgtmConfig.java
Outdated
Show resolved
Hide resolved
...lity-devservices/common/src/main/java/io/quarkus/observability/common/config/LgtmConfig.java
Outdated
Show resolved
Hide resolved
| .orElse("/metrics"); | ||
| String httpPortKey = isTest ? "quarkus.http.test-port" : "quarkus.http.port"; | ||
| Optional<Integer> optionalValue = runtimeConfig.getOptionalValue(httpPortKey, Integer.class); | ||
| int httpPort = optionalValue.orElse(isTest ? 8081 : 8080); // when not set use default |
There was a problem hiding this comment.
This is very confusing and brittle, but I have no better suggestions.
There was a problem hiding this comment.
Yeah, and the interesting thing is, this orElse actually kicks in at the end, as the prop is Optional.empty().
...ices/testcontainers/src/main/java/io/quarkus/observability/testcontainers/LgtmContainer.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alesj
force-pushed
the
dash_1
branch
2 times, most recently
from
d620c8b to
b50701a
Compare
This comment has been minimized.
This comment has been minimized.
brunobat
approved these changes
Jan 22, 2025
Status for workflow
|
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | JVM Tests - JDK 17 | Build |
Failures | Logs | Raw logs | 🔍 |
| ✖ | JVM Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
| ✖ | JVM Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 17 #
- Failing: integration-tests/observability-lgtm-prometheus
📦 integration-tests/observability-lgtm-prometheus
✖ io.quarkus.observability.test.LgtmTest.testPoke line 35 - History - More details - Source on GitHub
org.awaitility.core.ConditionTimeoutException: Lambda expression in io.quarkus.observability.test.LgtmTest expected the predicate to return <true> but it returned <false> for input of <QueryResult{status='success', data=Data{resultType='vector', result=[]}}> within 1 minutes 1 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:712)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:729)
at io.quarkus.observability.test.LgtmTest.testPoke(LgtmTest.java:35)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
⚙️ JVM Tests - JDK 21 #
- Failing: integration-tests/observability-lgtm-prometheus
📦 integration-tests/observability-lgtm-prometheus
✖ io.quarkus.observability.test.LgtmTest.testPoke line 35 - History - More details - Source on GitHub
org.awaitility.core.ConditionTimeoutException: Lambda expression in io.quarkus.observability.test.LgtmTest expected the predicate to return <true> but it returned <false> for input of <QueryResult{status='success', data=Data{resultType='vector', result=[]}}> within 1 minutes 1 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:712)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:729)
at io.quarkus.observability.test.LgtmTest.testPoke(LgtmTest.java:35)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
⚙️ JVM Tests - JDK 17 Windows #
- Failing: integration-tests/observability-lgtm-prometheus
📦 integration-tests/observability-lgtm-prometheus
✖ io.quarkus.observability.test.LgtmTest.testPoke - History - More details - Source on GitHub
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.observability.deployment.ObservabilityDevServiceProcessor#startContainers threw an exception: java.lang.RuntimeException: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration
at io.quarkus.observability.deployment.ObservabilityDevServiceProcessor.lambda$startContainers$4(ObservabilityDevServiceProcessor.java:181)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at io.quarkus.observability.deployment.ObservabilityDevServiceProcessor.startContainers(ObservabilityDevServiceProcessor.java:115)
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
Flaky tests - Develocity
⚙️ Maven Tests - JDK 17
📦 integration-tests/devmode
✖ io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService - History
Too many recursions, message not returned for id [318868145]-java.lang.RuntimeException
java.lang.RuntimeException: Too many recursions, message not returned for id [318868145]
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:164)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
Too many recursions, message not returned for id [1607583741]-java.lang.RuntimeException
java.lang.RuntimeException: Too many recursions, message not returned for id [1607583741]
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:164)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
⚙️ Gradle Tests - JDK 17 Windows
📦 integration-tests/gradle
✖ io.quarkus.gradle.devmode.MavenExclusionInExtensionDependencyDevModeTest.main - History
Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds.-org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds.
at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:164)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 3 items from this issue: #43599
Increase the scraper frequency
In devmode, increase default output rate so data shows quicker on the dashboards
Only activate the scraper if the Prometheus registry is present.