-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebalance native CI jobs so that Misc4 is not twice the duration of other jobs #45750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @holly-cummins!
This comment has been minimized.
This comment has been minimized.
|
Yeah, that's been pretty flaky |
Will take a look at that test |
Hi @gsmet, are you able to look at this? |
@holly-cummins it's on my list for today. Wanted to get @brunobat's PR first as one of them was conflicting and this one is the easy one. |
(I'm currently having a look at the LGTM timeouts) |
I'll do the rebase against #43831. |
f704adc
to
a7da9ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes a lot of sense, thanks!
I merged as the native tests passed. |
This PR aims to help these problems:
To address these, I moved the gradle tests to the Devtools job, since it’s one of the fastest. Then I noticed that almost everything that was left was observability-related, so I renamed the job and distributed the non-observability projects through the other jobs. I also moved maven in with gradle, since they seem like a logical grouping.
I think there are a few risks with this kind of change
@brunobat could you validate the contents of the observability bucket look like a complete-ish consistent set?
Here’s the timings I observed on my test runs. The codebases are a bit different between the two, but it shows the ratios.
Old
Misc 1: 31m
Misc 2: 22m
Misc 3: 30m
Misc 4: 54m (often it’s over an hour for me)
DevTools: 4m (!)
New
Misc 1: 26m
Misc 2: 29m
Misc 3: 28m
Observability: 35m
Build tools and DevTools: 29m