-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PathTreeClassPathElement#toString() implementation #45799
base: main
Are you sure you want to change the base?
Conversation
It was relying on some internal behavior of the path trees and not calling the `getOriginalTree()` method. But rather than fixing it this way, I think it's more future proof to properly implement `toString()` in the `PathTree` implementations. Fixes quarkusio#45650
64a72be
to
de05681
Compare
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | Native Tests - Misc1 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ Native Tests - Misc1 #
- Failing: integration-tests/maven
📦 integration-tests/maven
✖ io.quarkus.maven.it.NativeAgentIT.testRunIntegrationTests
line 27
- History - More details - Source on GitHub
org.opentest4j.AssertionFailedError:
expected: 0
but was: 1
at io.quarkus.maven.it.NativeAgentIT.testRunIntegrationTests(NativeAgentIT.java:27)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
📦 integration-tests/maven/target/test-classes/projects/native-agent-integration
✖ org.acme.FruitsEndpointTest.testListAllFruits
- History - More details - Source on GitHub
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=docker.io/postgres:17, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@210a7452)
at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.startDevDb(DevServicesDatasourceProcessor.java:369)
at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.launchDatabases(DevServicesDatasourceProcessor.java:121)
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.j...
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 integration-tests/opentelemetry
✖ io.quarkus.it.opentelemetry.MetricsTest.directCounterTest
- History
Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
-org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:57)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
⚙️ Native Tests - HTTP
📦 integration-tests/rest-client-reactive
✖ io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans
- History
expected: <1> but was: <2>
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:789)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
It was relying on some internal behavior of the path trees and not calling the
getOriginalTree()
method.But rather than fixing it this way, I think it's more future proof to properly implement
toString()
in thePathTree
implementations.Fixes #45650