Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register more elements to prevent unregistered accesses at runtime #45824

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Register more elements to prevent unregistered accesses at runtime #45824

merged 3 commits into from
Jan 23, 2025
+37 −5

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jan 23, 2025

  • Register methods reflectively accessed by micrometer
  • Register properties file accessed by postgresSQL driver
  • Register org.postgresql.jdbc.PgConnection.getSchema method

Relates to #41995

@zakkak zakkak requested a review from yrodiere January 23, 2025 12:30
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/jdbc Issues related to the JDBC extensions area/metrics labels Jan 23, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 23, 2025

/cc @brunobat (micrometer), @ebullient (micrometer), @gsmet (hibernate-orm)

@zakkak zakkak requested a review from brunobat January 23, 2025 12:34
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@zakkak zakkak force-pushed the 2025-01-23-micrometer-processor-registrations branch from 939a293 to 057ef7a Compare January 23, 2025 12:53
yrodiere
yrodiere reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest some minor changes, but otherwise LGTM. Thanks.

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java Outdated Show resolved Hide resolved
...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java Show resolved Hide resolved
@zakkak zakkak force-pushed the 2025-01-23-micrometer-processor-registrations branch from 057ef7a to e35f992 Compare January 23, 2025 13:41
@zakkak zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 23, 2025
@zakkak
Copy link
Contributor Author

zakkak commented Jan 23, 2025

I'd suggest some minor changes, but otherwise LGTM. Thanks.

Thank you for the review @yrodiere. I addressed both comments.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 23, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e35f992.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit c91718e into quarkusio:main Jan 23, 2025
45 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 23, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 23, 2025
@zakkak zakkak deleted the 2025-01-23-micrometer-processor-registrations branch January 23, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobat brunobat brunobat approved these changes

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/jdbc Issues related to the JDBC extensions area/metrics
Projects
None yet
Milestone
3.19 - main
Development

Successfully merging this pull request may close these issues.
4 participants
@zakkak @yrodiere @brunobat @geoand