Add new openshift-s2i-guide #126
Conversation
|
Maybe we should explain some of the non obvious points in the guide? |
_guides/openshift-s2i-guide.adoc
Outdated
| [source,shell] | ||
| ---- | ||
| # To build the image on OpenShift | ||
| oc new-app fabric8/s2i-java:latest-java11~https://github.com/quarkusio/quarkus-quickstarts --context-dir=getting-started-openshift-s2i --name=quarkus-quickstart |
There was a problem hiding this comment.
I am not sure if Fabric8 images should be promoted in the quickstarts. Is that the officially supported Java 11 S2I image?
quarkusio#1306 see also quarkusio#1305 requires quarkusio/quarkus-quickstarts#81 and then to actually publish the link to this new guide in the menu it needs quarkusio/quarkusio.github.io#126
because that's actually coming from another repo, so quarkusio/quarkus#1353
gsmet
changed the title
@geoand I'm all for it... please feel free to follow up with more PRs on top of this work to improve it! @gastaldi lemme try that other image (which ... there is whole other story.. anyway). Just FYI |
@geoand @gastaldi #1353 now has a Background chapter with some blurb about what's going on. |
|
Now that both quarkusio/quarkus-quickstarts#81 as well as quarkusio/quarkus#1353 have been merged, this is ready to go in (I'll Resolve the Conflict ASAP). |
|
Strictly speaking, https://github.com/quarkusio/quarkus/pull/1353/files only added doc for Java not Native S2I Building, but the README from https://github.com/quarkusio/quarkus/pull/1358/files has that, and quarkusio/quarkus#1801 will bring it to https://quarkus.io, so to "fit in" the menu as-is now, I think this header makes sense. @tqvarnst @siamaksade @cescoffier @gastaldi @geoand OK for you? @dandreadis @dneary FYI |
cescoffier
changed the title
|
My mistake, this would need to be re-applied after the release. |
see quarkusio/quarkus-quickstarts#81
see quarkusio/quarkus#1353