-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder 'features' on front page to emphasise performance #2179
Conversation
d265f39
to
9b7f552
Compare
🙈 The PR is closed and the preview is expired. |
More I read kubernetes and Container more I think they should be somewhat merged. |
I have often thought the same. I think the main reason to keep them separate is the symmetry of the front page, so that we have an even number of features. (They also fit quite nicely into the 'supports' column scheme and reinforce it, but I might be the only one who'll really notice that extra layer of meaning in the layout.) |
…ar menus to match order Also updated to add 'supports' semantics in all of the vertical columns, not just the first one, and make developer joy most prominent.
908eb18
to
cf08e63
Compare
Sorry, have been out on holiday last week. Keep in mind that the page is responsive and there isn't an intent to have columns of content as in mobile, it all turns to a single column. We also have the DevUI content coming up for consideration. I mentioned there that that content feels like it should be added to this band (and not have it's own band). This would mean we'll have 7 bits of content to order, unless we combine the Container/Kube page and add a redirect for the abandoned page. I agree that the Container/Kube pages can be combined. |
Let's separate out the combining of container and kube from the problem this PR is solving, which is "do not have performance and developer joy be the least important things in the list." I agree that if we add dev ui, that would be a good opportunity to combine them, to avoid going to seven benefits (which is too many to quickly take in). |
+1 on just having this reoroderd to have devjoy higher. devui I'm not sure make sense to have in this but lets have that in separate pr/issue if we got some reasons for it. |
The Dev UI work is heppening in this PR: #2178 |
The current order has developer joy and performance as the least prominent benefits, which isn't ideal:
I've also updated the order of the navbar menus to match the new order. (It didn't quite match the old order, either. :) )