Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder 'features' on front page to emphasise performance #2179

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented Nov 28, 2024

The current order has developer joy and performance as the least prominent benefits, which isn't ideal:

image

I've also updated the order of the navbar menus to match the new order. (It didn't quite match the old order, either. :) )

Copy link

github-actions bot commented Nov 28, 2024

🙈 The PR is closed and the preview is expired.

@holly-cummins
Copy link
Contributor Author

New order:
image

I tried to line things up vertically, too, so 'reactive core' supports 'performance'. I perhaps should have carried that on and had 'standards' supporting 'developer joy' and 'container first' supporting 'kube native'.

@holly-cummins
Copy link
Contributor Author

Revision. Now there's (very very loose) 'supports/enables' semantics on each column:
image

@cescoffier
Copy link
Member

More I read kubernetes and Container more I think they should be somewhat merged.

@holly-cummins
Copy link
Contributor Author

More I read kubernetes and Container more I think they should be somewhat merged.

I have often thought the same. I think the main reason to keep them separate is the symmetry of the front page, so that we have an even number of features. (They also fit quite nicely into the 'supports' column scheme and reinforce it, but I might be the only one who'll really notice that extra layer of meaning in the layout.)

…ar menus to match order

Also updated to add 'supports' semantics in all of the vertical columns, not just the first one, and make developer joy most prominent.
@insectengine
Copy link
Collaborator

Sorry, have been out on holiday last week.

Keep in mind that the page is responsive and there isn't an intent to have columns of content as in mobile, it all turns to a single column. We also have the DevUI content coming up for consideration. I mentioned there that that content feels like it should be added to this band (and not have it's own band). This would mean we'll have 7 bits of content to order, unless we combine the Container/Kube page and add a redirect for the abandoned page. I agree that the Container/Kube pages can be combined.

@holly-cummins
Copy link
Contributor Author

Sorry, have been out on holiday last week.

Keep in mind that the page is responsive and there isn't an intent to have columns of content as in mobile, it all turns to a single column. We also have the DevUI content coming up for consideration. I mentioned there that that content feels like it should be added to this band (and not have it's own band). This would mean we'll have 7 bits of content to order, unless we combine the Container/Kube page and add a redirect for the abandoned page. I agree that the Container/Kube pages can be combined.

Let's separate out the combining of container and kube from the problem this PR is solving, which is "do not have performance and developer joy be the least important things in the list." I agree that if we add dev ui, that would be a good opportunity to combine them, to avoid going to seven benefits (which is too many to quickly take in).

@maxandersen
Copy link
Member

+1 on just having this reoroderd to have devjoy higher.

devui I'm not sure make sense to have in this but lets have that in separate pr/issue if we got some reasons for it.

@maxandersen maxandersen merged commit e05b5f9 into quarkusio:main Dec 3, 2024
1 check passed
@holly-cummins
Copy link
Contributor Author

devui I'm not sure make sense to have in this but lets have that in separate pr/issue if we got some reasons for it.

The Dev UI work is heppening in this PR: #2178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants