Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule based editor #151

Merged
merged 22 commits into from
May 10, 2016
+2,218 −3
Merged

Rule based editor #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4cc3f7d
Import Rule-based Editor from ncm-dpmlfc
jouvin Apr 23, 2016
0d01b25
RuleBasedEditor.pm: fix calling sequence for reporting methods
jouvin Apr 23, 2016
f5a2f06
import rule-based editor unittests from ncm-dpmlfc (value_format)
jouvin Apr 23, 2016
70e02a8
RuleBasedEditor: import unit test remove_variable from ncm-dpmlfc
jouvin Apr 23, 2016
dea2dc5
RuleBasedEditor: import unit test build_line_pattern.t from ncm-dpmlfc
jouvin Apr 23, 2016
8f7e5b3
RuleBasedEditor: import unit test rule_parser.t from ncm-dpmlfc
jouvin Apr 23, 2016
8870bee
RuleBasedEditor: update constant names to be independent from ncm-dpm…
jouvin Apr 23, 2016
9aa3d33
RuleBasedEditor: misc. refactoring in unit tests
jouvin Apr 23, 2016
da657f1
RuleBasedEditor: document rule format + misc. doc improvements
jouvin Apr 23, 2016
8f23841
RuleBasedEditor: convert into a subclass of the FileEditor
jouvin Apr 24, 2016
6f77a5a
RuleBaseEditor.pm: address initial comments by @stdweird in #151
jouvin Apr 24, 2016
55eb207
RuleBasedEditor: general reformatting with perl-Tidy
jouvin Apr 25, 2016
fc9e50e
RuleBasedEditor: updateFile() returns 1 on success (instead of 0)
jouvin Apr 25, 2016
e317678
FileEditor: remove unnecessary 'use' for modules in 'use parent'
jouvin Apr 25, 2016
fb50d1d
RuleBasedEditor: improve pod documentation
jouvin Apr 25, 2016
2478919
RuleBasedEditor: cleanup in tests
jouvin Apr 25, 2016
23469cb
RuleBasedEditor: address @ned21 comments in PR 151
jouvin May 1, 2016
c9b50c2
RuleBaseEditor: rename method _removeConfigLine into _commentConfigLine
jouvin May 8, 2016
0b1529f
RuleBasedEditor: comment clarifications and typo fixes
jouvin May 8, 2016
f0c06fb
RuleBasedEditor: cleanup of method return values
jouvin May 8, 2016
a3a4a03
RuleBasedEditor: additional comment cleanups and clarifications
jouvin May 8, 2016
95b3896
RuleBasedEditor: fix a regexp not compatible with perl 5.8 (SL5)
jouvin May 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/perl/FileEditor.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,10 @@ package CAF::FileEditor;

use strict;
use warnings;
use CAF::FileWriter;
use LC::File;
use Exporter;
use Fcntl qw(:seek);

our @ISA = qw (CAF::FileWriter Exporter);
use parent qw(CAF::FileWriter Exporter);
our @EXPORT = qw(BEGINNING_OF_FILE ENDING_OF_FILE);

use constant BEGINNING_OF_FILE => (SEEK_SET, 0);
Expand All @@ -24,6 +22,7 @@ use constant IO_SEEK_END => (0, SEEK_END);

use constant SYSCONFIG_SEPARATOR => '=';


=pod

=head1 NAME
Expand Down
Loading