Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProfileCache: Include type in checksum calculation #216

Merged
merged 1 commit into from
Nov 29, 2024
Merged

ProfileCache: Include type in checksum calculation #216

merged 1 commit into from
Nov 29, 2024

Conversation

jrha
Copy link
Member

@jrha jrha commented Nov 11, 2024

Resolves #213.

@jrha jrha added this to the 25.next milestone Nov 11, 2024
@jrha jrha force-pushed the checksum_type branch 3 times, most recently from b777537 to 7115dcd Compare November 28, 2024 10:34
@jrha jrha marked this pull request as ready for review November 28, 2024 10:44
@jrha jrha requested review from stdweird and ned21 November 28, 2024 11:05
@ned21
Copy link
Contributor

ned21 commented Nov 28, 2024

I don't really follow what's wanted here based on the brief description in #213. The code seems fine 🤷 but unclear if the overall goal is useful and how this helps?

@jrha
Copy link
Member Author

jrha commented Nov 28, 2024

Apologies, the detail has been lost along the way.
The goal here is to eventually be able to recompute a checksum for the whole profile to verify integrity, but the current checksums don't include type allowing that to be altered or corrupted without being detected.

@jrha
ProfileCache: Include type in checksum calculation
aed2f3f 
The goal here is to eventually be able to recompute a checksum for the whole profile to verify integrity,
this requires the checksums to include type so that alteration or corruption of type can be detected.

N.B. \x1e is the record separator character, used here to delimit the value and type.
@jrha
Copy link
Member Author

jrha commented Nov 28, 2024

See also #161.

@jrha jrha merged commit 2e95e6a into quattor:master Nov 29, 2024
1 check passed
@jrha jrha deleted the checksum_type branch November 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned21 ned21 ned21 approved these changes

@stdweird stdweird Awaiting requested review from stdweird

Assignees
No one assigned
Labels
None yet
Milestone
25.next
Development

Successfully merging this pull request may close these issues.

Include type information in checksum computation
2 participants
@jrha @ned21