Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions #1

Merged
merged 14 commits into from
Dec 19, 2024
Merged

GitHub actions #1

merged 14 commits into from
Dec 19, 2024

Conversation

maxdinkel
Copy link
Contributor

@maxdinkel maxdinkel commented Dec 19, 2024

Description and Context

This PR adds the ci pipeline for github.

Related Issues and Merge Requests

  • Closes
  • Blocks
  • Is blocked by
  • Follows
  • Precedes
  • Related to
  • Part of
  • Composed of

How Has This Been Tested?

  • codechecks
  • unit_tests
  • integration_tests
  • integration_tests_fourc

Checklist

  • My commit messages mention the appropriate issue numbers (advised but optional).
  • I mention the appropriate issue numbers in this MR.
  • I updated documentation where necessary.
  • I updated the README where necessary
  • I have added as (few,) small and fast tests as possible to cover my changes.

Additional Information

Interested Parties

Possible reviewers:

Other interested parties:

@maxdinkel
Copy link
Contributor Author

Once we go public, we should be able to reset the last commit because then the testing machine should have 2 cores available.

@maxdinkel
Copy link
Contributor Author

Shoutout to @ppraegla for his help! 🙇

@maxdinkel maxdinkel requested review from gilrrei and removed request for sbrandstaeter December 19, 2024 11:39
- name: codechecks
run: |
$PYTHON_PACKAGE_MANAGER activate queens
isort --check-only queens tests > track_isort.txt 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should add the checks of the license headers.

There should however already be a GitHub Action for that https://github.com/apache/skywalking-eyes

shell: bash -l {0}
steps:
- uses: actions/checkout@v4
- uses: conda-incubator/setup-miniconda@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ensure the conda-forge channel in our environment.yml file but if possible using miniforge would also enable us to use the faster mamba environment manager.

ln -s /home/user/4C/build/4C config/4C
ln -s /home/user/4C/build/post_ensight config/post_ensight
ln -s /home/user/4C/build/post_processor config/post_processor
# /usr/bin/mpirun --bind-to none --use-hwthread-cpus -np 2 config/4C /home/user/4C/tests/input_files/solid_runtime_hex8.dat out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this comment be deleted?

@maxdinkel
Copy link
Contributor Author

Let's resolve the open points in a follow up.

@maxdinkel maxdinkel merged commit 17a43ac into main Dec 19, 2024
1 check passed
@maxdinkel maxdinkel deleted the github-actions branch December 19, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants