Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --use-hwthread-cpus flag and trigger on pull request #2

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

maxdinkel
Copy link
Contributor

@maxdinkel maxdinkel commented Dec 19, 2024

Description and Context

As queens is public now, we have more cores available on the test runner and can therefore remove the --use-hwthread-cpus flag for the mpi command.

The trigger for the ci is changed to pull_request.

Related Issues and Merge Requests

  • Closes
  • Blocks
  • Is blocked by
  • Follows
  • Precedes
  • Related to
  • Part of
  • Composed of

How Has This Been Tested?

Checklist

  • My commit messages mention the appropriate issue numbers (advised but optional).
  • I mention the appropriate issue numbers in this MR.
  • I updated documentation where necessary.
  • I updated the README where necessary
  • I have added as (few,) small and fast tests as possible to cover my changes.

Additional Information

Interested Parties

Possible reviewers:

Other interested parties:

@maxdinkel maxdinkel requested a review from gilrrei December 19, 2024 13:32
@maxdinkel maxdinkel self-assigned this Dec 19, 2024
sbrandstaeter
sbrandstaeter previously approved these changes Dec 19, 2024
Copy link
Contributor

@sbrandstaeter sbrandstaeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@maxdinkel maxdinkel changed the title Remove --use-hwthread-cpus flag Remove --use-hwthread-cpus flag and trigger on pull request Dec 19, 2024
@maxdinkel maxdinkel merged commit 25b701f into queens-py:main Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants