Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This is an alternative implementation of merge request !786 on GitLab that improves the error handling in our jobscript driver. This new implementation introduces a flag to the
JobscriptDriver
that determines whether to raise an error if the jobscript returns a non-zero exit code.This new implementation does not introduce a second constructor and, therefore, does not break the input-file-based workflow.
In addition, the new error handling allows for catching OSErrors which used to occur when the
jobscript_template
string was too long.Related Issues and Merge Requests
How Has This Been Tested?
Checklist
Additional Information
Interested Parties
Possible reviewers:
Other interested parties: