Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(readme): add test for the example in the readme #91

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

gilrrei
Copy link
Contributor

@gilrrei gilrrei commented Jan 10, 2025

Description and Context

This PR adds a test for the QUEENS example in the readme. It does not check if the output is correct, only if it runs without exit code. This is to ensure that the example remains working and highlights if this is not the case.

The function to extract the source from the readme could also be added to the conf.py of the sphinx documentation to add this example as a tutorial.

Related Issues and Pull Requests

  • Closes
  • Blocks
  • Is blocked by
  • Follows
  • Precedes
  • Related to
  • Part of
  • Composed of

How Has This Been Tested?

Checklist

  • My commit messages mention the appropriate issue numbers (advised but optional).
  • I mention the appropriate issue numbers in this PR.
  • I updated documentation where necessary.
  • I have added tests to cover my changes.

Additional Information

Interested Parties

Possible reviewers: @leahaeusel @sbrandstaeter @maxdinkel

Other interested parties:

@gilrrei gilrrei force-pushed the add_test_for_readme_example branch from 4d496ba to 0d6a3bf Compare January 10, 2025 09:28
Copy link
Contributor

@leahaeusel leahaeusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks for the test!

test_utils/get_example_in_read_me.py Outdated Show resolved Hide resolved
@gilrrei gilrrei force-pushed the add_test_for_readme_example branch from a8f7fb0 to dd0ed51 Compare January 10, 2025 10:41
license_header.tmpl Show resolved Hide resolved
@gilrrei gilrrei force-pushed the add_test_for_readme_example branch from dd0ed51 to fb0a743 Compare January 10, 2025 11:38
sbrandstaeter
sbrandstaeter previously approved these changes Jan 10, 2025
leahaeusel
leahaeusel previously approved these changes Jan 10, 2025
@gilrrei gilrrei dismissed stale reviews from leahaeusel and sbrandstaeter via edce564 January 10, 2025 13:57
@gilrrei gilrrei force-pushed the add_test_for_readme_example branch from fb0a743 to edce564 Compare January 10, 2025 13:57
@gilrrei gilrrei merged commit e403555 into queens-py:main Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants