Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #98

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Conversation

gilrrei
Copy link
Contributor

@gilrrei gilrrei commented Jan 14, 2025

Description and Context

This PR improves documentation by adding information from the README.md, CONTRIBUTING.md and tests/README.md . Also, links to the repo and website are added.

Ok this PR escalated a bit, so here is a list of changes:

  • Logos are added to the doc folder. This way everything works offline and users won't be redirected to any other page. At documentation builds, new logos will be pulled, and this should be added to the update workflow that is incoming
  • I generalized the marker in markdown approach to be able to extract sections from markdown files to the documentation. Still not sure if this is genius or madness. Tbh it works pretty stable
  • There now is a Development tab that includes the contents of the testing README and Contributing such as installing, license etc
  • The architecture overview was renamed into modules overview. Here, the module description found in queens_subpackage/__init__.py is added. So no need to maintain a separate description. On this, I updated the descriptions a bit, but feedback is welcome.
  • The QUEENS example in the readme is added to the tutorial's example
  • I introduced a custom sphinx extension that basically just calls a python script that builds the prerequisites for the documentation mentioned above
  • The custom script mostly gathers information from different sources and based on jinja templates creates the files for sphinx to generate the HTML with
  • I introduced the sphinx extension myst_parser, which allows adding markdown files besides rst.

Thanks to @leahaeusel's PR you can preview the HTML documentation by downloading the artifact from the documentation build

Related Issues and Pull Requests

  • Closes
  • Blocks
  • Is blocked by
  • Follows
  • Precedes
  • Related to
  • Part of
  • Composed of

How Has This Been Tested?

Checklist

  • My commit messages mention the appropriate issue numbers (advised but optional).
  • I mention the appropriate issue numbers in this PR.
  • I updated documentation where necessary.
  • I have added tests to cover my changes.

Additional Information

Interested Parties

Possible reviewers:

Other interested parties:

@gilrrei gilrrei force-pushed the improve_documentation branch from c17a726 to 406dd7e Compare January 14, 2025 16:50
@gilrrei gilrrei marked this pull request as draft January 15, 2025 13:29
@gilrrei gilrrei force-pushed the improve_documentation branch 14 times, most recently from 50a44a8 to 8acde80 Compare January 18, 2025 09:46
@gilrrei gilrrei marked this pull request as ready for review January 18, 2025 10:02
@gilrrei
Copy link
Contributor Author

gilrrei commented Jan 18, 2025

The reason for introducing the custom extension to extract information from different places is to avoid maintaining the same information in various places in QUEENS. The goal was to have as much information as possible in the source code, such that on changes, renaming, moving the to different locations, the documentation should still work

Copy link

@mayrmt mayrmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gilrrei I was curious, so I had a look... while at it, I left some comments...

queens/drivers/__init__.py Outdated Show resolved Hide resolved
doc/source/index.rst Outdated Show resolved Hide resolved
queens/example_simulator_functions/__init__.py Outdated Show resolved Hide resolved
queens/parameters/__init__.py Outdated Show resolved Hide resolved
queens/utils/__init__.py Outdated Show resolved Hide resolved
@gilrrei gilrrei force-pushed the improve_documentation branch from 8acde80 to 81b8b79 Compare January 20, 2025 08:52
@gilrrei
Copy link
Contributor Author

gilrrei commented Jan 20, 2025

@gilrrei I was curious, so I had a look... while at it, I left some comments...

Thanks, I added your suggestions.

@gilrrei gilrrei force-pushed the improve_documentation branch from 81b8b79 to 4e6d840 Compare January 20, 2025 13:12
Copy link
Contributor

@leahaeusel leahaeusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for cleaning up the documentation and implementing the new copying features! This will hopefully save us a lot of work in the future.

CONTRIBUTING.md Outdated Show resolved Hide resolved
doc/source/_ext/templates/tutorials.rst.j2 Outdated Show resolved Hide resolved
doc/source/_ext/create_documentation_files.py Outdated Show resolved Hide resolved
doc/source/_ext/queens_sphinx_extension.py Outdated Show resolved Hide resolved
doc/source/_ext/templates/intro.md.j2 Outdated Show resolved Hide resolved
queens/distributions/__init__.py Show resolved Hide resolved
queens/iterators/__init__.py Outdated Show resolved Hide resolved
queens/parameters/__init__.py Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
@gilrrei gilrrei force-pushed the improve_documentation branch from 4e6d840 to 4f68a11 Compare January 20, 2025 17:26
@gilrrei
Copy link
Contributor Author

gilrrei commented Jan 22, 2025

@queens-py/maintainers I "rewrote" the module descriptions as they are actively used in the documentation and needed the typical module description layout. Since this is a hot topic, I propose to keep the definitions as they currently are and go over them in the next developer meeting to finish this MR.

leahaeusel
leahaeusel previously approved these changes Jan 22, 2025
@gilrrei gilrrei force-pushed the improve_documentation branch from 4f68a11 to 9990800 Compare January 22, 2025 15:05
@gilrrei
Copy link
Contributor Author

gilrrei commented Jan 22, 2025

@queens-py/maintainers I "rewrote" the module descriptions as they are actively used in the documentation and needed the typical module description layout. Since this is a hot topic, I propose to keep the definitions as they currently are and go over them in the next developer meeting to finish this MR.

See #105

leahaeusel
leahaeusel previously approved these changes Jan 22, 2025
@gilrrei gilrrei merged commit 14320af into queens-py:main Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants