-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify macro rewriters and avoid some prospective bugs #238
base: master
Are you sure you want to change the base?
Conversation
I have no idea about the compatibility issues when Julia version is lower than v1.0 :( |
I'll look through the rest of the PR when I have bit more time, but just a quick response on this: I think we could probably drop julia 0.7 support at this point. I think we should keep 1.0 support, given that that is the long term supported version of julia. |
Perfect, I'd like to continue refactoring those macro rewriters. |
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 90.02% 90.75% +0.73%
==========================================
Files 5 5
Lines 441 411 -30
==========================================
- Hits 397 373 -24
+ Misses 44 38 -6
Continue to review full report at Codecov.
|
There seems to be some strange issues in Julia v1.0. I cannot solve it on my own so I went to community for help. https://discourse.julialang.org/t/strange-bug-segmentation-fault-11-solely-existed-in-julia-v1-0/21392 |
You may want to check this clean implementation of @select:
https://github.com/thautwarm/Query.jl/blob/34f6dbaf5aba156fafa9d60335126a7795f6b676/src/table_query_macros.jl#L49
Also, there're some prospective bugs that've been avoided, e.g., quoted
"
in fieldname of dataframes.