Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-config): add rest section #89

Closed

Conversation

idrissneumann
Copy link
Collaborator

Fix this issue: #62

@idrissneumann
Copy link
Collaborator Author

Tests okay:

Screenshot 2024-06-18 at 17 30 07

@idrissneumann idrissneumann marked this pull request as ready for review June 18, 2024 16:31
@idrissneumann
Copy link
Collaborator Author

Might be useless if #85 get merged (maybe we'll keep the comment in the value file once it get merged)

@rdettai
Copy link
Contributor

rdettai commented Jun 24, 2024

Yes this is completely superseded by #85! Closing it for now.

@rdettai rdettai closed this Jun 24, 2024
@idrissneumann idrissneumann deleted the feat_rest_config branch June 25, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants