remove Document: DocumentDeserialize dependency #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency requires users to implement an API they may not use.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2211 +/- ##
==========================================
- Coverage 94.03% 94.01% -0.02%
==========================================
Files 327 327
Lines 65013 65022 +9
==========================================
+ Hits 61132 61133 +1
- Misses 3881 3889 +8
☔ View full report in Codecov by Sentry. |
fulmicoton
reviewed
Oct 12, 2023
fulmicoton
reviewed
Oct 12, 2023
src/core/searcher.rs
Outdated
| @@ -104,7 +107,10 @@ impl Searcher { | |||
|
|
|||
| /// Fetches a document in an asynchronous manner. | |||
| #[cfg(feature = "quickwit")] | |||
| pub async fn doc_async<D: Document>(&self, doc_address: DocAddress) -> crate::Result<D> { | |||
| pub async fn doc_async<D: Document + DocumentDeserialize>( | |||
There was a problem hiding this comment.
same question as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency requires users to implement an API they may not use.