bump index version #2237
Merged
bump index version #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Nov 2, 2023
| @@ -103,7 +103,7 @@ impl Footer { | |||
| /// Has to be called after `extract_footer` to make sure it's not accessing uninitialised memory | |||
| pub fn is_compatible(&self) -> Result<(), Incompatibility> { | |||
| let library_version = crate::version(); | |||
| if self.version.index_format_version < 4 | |||
There was a problem hiding this comment.
nitpick
const SUPPORTED_INDEX_FORMAT_VERSION_RANGE: Range<u32> = INDEX_FORMAT_OLDEST_SUPPORTED_VERSION..=INDEX_FORMAT_VERSION;
if !SUPPORTED_VERSION_RANGE.contains(&self.version.index_format_version) {
// ...
}
fulmicoton
approved these changes
Nov 2, 2023
and add constant for lowest supported version
trinity-1686a
force-pushed
the
trinity--bump-index-version
branch
from
22ca55e to
329e35e
Compare
PSeitz
pushed a commit
that referenced
this pull request
Apr 10, 2024
* bump index version and add constant for lowest supported version * use range instead of handcoded bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2236
we already have some logic to allow older index revision, but it's an unnamed constant hidden somewhere. I moved it alongside the current version