eureka: Add a BA Portal Timer to Hydatos #3764
Conversation
|
@KattTails Thanks for your contribution! 🌵🚀 |
KattTails
changed the title
|
cactbot bot doesn't like capitals :( |
| @@ -251,6 +252,15 @@ | |||
| border-bottom: 2px dashed rgba(255, 255, 255, 0.3); | |||
| } | |||
|
|
|||
| #portal-timer-container { | |||
There was a problem hiding this comment.
What do you think about combining these with weather (like on top of the current weather?) just to avoid having too many boxes spread about?
There was a problem hiding this comment.
I decided on creating a separate box for it because the weather container is already pretty tall compared to the Hydatos map and I wanted to keep it as compact as possible.
The layout of the weather box is also pretty fixed, there's always the time of day and then 5 weathers visible, whereas the portal timer is only going to be popping up when it's relevant to be shown. I think that having the box resize and an extra element appearing/disappearing would be pretty distracting personally, but I'm open to others' thoughts on this.
| @@ -1,4 +1,4 @@ | |||
| <html lang="en-US"> | |||
| <html> | |||
There was a problem hiding this comment.
| <html> | |
| <html lang="en-US"> |
| @@ -11,6 +11,18 @@ export const bunnyLabel: LocaleText = { | |||
| ko: '토끼', | |||
| }; | |||
|
|
|||
| const sec2time = (timeInMs: number) => { | |||
There was a problem hiding this comment.
is this ms2time and not sec2time? or, maybe I misunderstand what "sec" means here?
This adds a new timer to the Hydatos map for tracking the blue/red BA portals in the same style as the weather info
Preview image:
I've also implemented a new check for nm.startTimerOnKill, which allows NMs/CEs such as Ovni, Castrum and the Dalriada to be tracked more accurately as a result.
If you want to test it quickly you can use this url:
https://katttails.github.io/cactbot/ui/eureka/eureka.htmlhowever do note that I've been doing some other work on top of this PR so there are some other unrelated code changes as well, but they shouldn't affect anything (I hope).
Needs translations.