Triggers? #4873
Closed
Triggers? #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 28, 2022 16:15
Co-authored-by: 迷子 (Maiko Tan) <[email protected]> 7b5d325
…rs (#4362) * raidboss: DRS Spiral Thrust Safe Spots * switch source from regex to array * lint * more lint * number to output * Add parenthesis * reduce delay down * refactor to use overlayHandler The startsUsing would get 5.7s, the length of the cast, at most, which really only gives about 3 seconds notice but players will already know before the beginning of the cast where to go based on the jumps the knights do at end of 63D3 Strength of the Ward cast from King Thordan. Need to determine delaySeconds value here. Also not sure if this same spell is cast later in the encounter. * fix lint warnings and errors * remove console log message * remove whitespace * Add callout for boss location after dives This also moves the matchedPositionToDir function globally as it would be used for multiple triggers * remove capture false, fix typo in error message * add sanctity ward direction Could also have a call out for 'light party' positions (east/west) when the boss goes untargetable. Then which direction movement will be once it has been determined. To also be determined on timing of that callout and what it should state. The idea is something like left/right or clockwise/counterclockwise to indicate to player which direction to first dodge the dashes. It can be all relative to center of arena (left/right), or to the top down view of the floor (clock/counterclock). May also want a 'move' to signify when to begin the movement, but that's typically aligned with the dash. * missed adding data * rename sanctityWardDirection to sanctityWardDir * reduce delaySeconds and Janlennoux name the Ward directions do not work, there are 3 Ser Janellnoux combatants, the other one I have to look at more I think there may be a name typed wrong or something. * reorder deletes * change filter to building new array * lint still trying to get Janlenoux position data * sort Janlenoux combatants, reduce delay on dives * adjust delayseconds for clock callout * fix case where dir is 0 * reduce thrust delay * increase thrust safe spot delay 1 in like 40 pulls got bad data. * remove some comments Not sure if this commit as is counts for Sanctity of the Ward left/right direction, player may need to swap clockwise/counterclockwise callout dependent on their strat. I don't know of any other conflicts. * switch to 1 move by default * Update ui/raidboss/data/06-ew/ultimate/dragonsongs_reprise_ultimate.ts Co-authored-by: Adrienne Walker <[email protected]> * Update ui/raidboss/data/06-ew/ultimate/dragonsongs_reprise_ultimate.ts Co-authored-by: Adrienne Walker <[email protected]> * Update ui/raidboss/data/06-ew/ultimate/dragonsongs_reprise_ultimate.ts Co-authored-by: Adrienne Walker <[email protected]> * Update Sanctity Ward Direction comment * Add Adelphel Charge Start Direction * adjust time and lint * fix comment spellid * adjust delaySeconds I'll see about getting heading written into this next * adjust adelphel charge delay * this seems to work at 4.7 * lint * more commentry from pr comments * remove TODO. * add 4dir, change to compare x for janlenoux * fix missing output parameter * lint Co-authored-by: Adrienne Walker <[email protected]> cfdf8ca
Co-authored-by: Adrienne Walker <[email protected]> d840b96
Co-authored-by: nickd-2 <[email protected]> 741317c
added 27 commits
September 9, 2022 17:48
Thanks always for the updates bd0cee3
```
334.6 "Aetheronecrosis 3" sync / 1[56]:[^:]*:Hegemone:7877:/
334.8 "Dual Predation" sync / 1[56]:[^:]*:Hegemone:7878:/
335.8 "Predation 1" sync / 1[56]:[^:]*:Hegemone:(787A|787B):/
338.7 "Aetheronecrosis 4" sync / 1[56]:[^:]*:Hegemone:7877:/
```
When I initially wrote this, I assumed that since every ability was more
than 2.5s apart, everything was fine. However, Aetheronecrosis 3 looks
ahead enough to sync with an early fourth usage immediately after
Predation 1. Because of this, it's possible to be behind by about 3-4
seconds during the rest of the Predation usages. It's not always going
to happen, but when it does, it looks like this:
```
334.568: Matched entry: 334.6 Aetheronecrosis 3 (+0.032s)
334.865: Matched entry: 334.8 Dual Predation (-0.065s)
335.737: Matched entry: 335.8 Predation 1 (+0.063s)
336.468: Matched entry: 334.6 Aetheronecrosis 3 (-1.868s)
336.468: Matched entry: 338.7 Aetheronecrosis 4 (+2.232s)
342.087: Matched entry: 339.9 Predation 2 (-2.187s)
342.087: Matched entry: 343.9 Predation 3 (+1.813s)
347.907: Matched entry: 347.9 Predation 4 (-0.007s)
388.405: Matched entry: 384.3 Hemitheos's Dark IV (-4.105s)
Warning: 40.505s since last sync
Missed sync: Ptera Ixou at 356.9 (last seen at 360.96299999999997)
Missed sync: Synergy at 372.2 (last seen at 376.289)
394.949: Matched entry: 395.0 Aetheric Polyominoid (+0.051s)
```
It is technically only necessary to remove the syncs from 3/4, but
stylistically I felt that it made more sense to remove them all and let
the Predations handle any necessary syncs.
(Stuff like this is why we add those giant 30,30 safety syncs all over,
specifically to keep this kind of thing from breaking the entire
encounter!) 944b875
Added CN translations for p6s `predation`. 38d9e3c
This is probably ok, but it's also like ~2s after the first visual so it feels late. 9b6e73b
Adds direction based on OverlayPlugin Heading. Current delay is what was safe for e12s, it may be possible that the boss here turns sooner... 8f9642e
https://github.com/quisquous/cactbot/blob/51f03c06e4f428e89280daf8744a680601a851a5/ui/raidboss/data/06-ew/raid/p8s.ts#L611-L620 @kshman It seems that Japanese 'cardinal' and 'intercardinal' are reversed here. cardinal: ➕, intercardinal: ❌ 224583c
Boss apparently can face -3.13727832 as well being North. 26cdbf7
P8S JP add new translations modify some translations 3cb6e6a
…4853) Sometimes roles don't work and so this can cause bugs. This only considers individual debuffs. Borrowed/modified from valarnin's comment here: OverlayPlugin/OverlayPlugin#60 (comment) 08ddad9
Adds three callouts: - A silent counter - An audible Bait and Tower number - Soak Tower when safe to move The Counter is based on Tyrant's Fire III (75F0). The Soak Tower is based on Tyrant's Flare II (7A88) puddles, it could have been just a delayed trigger from the Tyrant's Fire III, but possibly this is a cleaner solution for timings? 96a5fc9
Adds a callout for all and a reminder. It looked like the targetX and targetY data of the 793D and 793C spells could be used to resolve this without OverlayPlugin. ef4469a
This also includes a few fixes to make these triggers work better: * target-less tankbusters (b/c there's too many people around) are now handled * `resetWhenOutOfCombat: false` now properly sets `inCombat` rather than just ignoring changes to combat * to avoid clearing any stored `data` fields when engaging a mob, set `resetWhenOutOfCombat: false` in a few places d425330
|
@AngelSeed Thanks for your contribution! 🌵🚀 Currently your title is:
Did you mean: More Information
Multiple scopes can be combined with slashes if needed, e.g. Valid Title Examples:
Drafts can also use Breaking changes can use This comment is created and updated by a bot. |
|
duplicated with #3000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gyazo.com/cba21f677d2de90c39f06516b3ffbe0e
For example, is it possible to change this (${player}) to the job notation instead of the player name?
If you're a player, the player name will be different every time you're attacking as a stray.