Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub client #318

Merged
merged 16 commits into from
Jan 14, 2025
Merged

GitHub client #318

merged 16 commits into from
Jan 14, 2025

Conversation

TheKrol
Copy link
Contributor

@TheKrol TheKrol commented Dec 30, 2024

Putting this here for notice

zleyyij
zleyyij requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@zleyyij zleyyij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far, just some minor tweaks

backend/src/gh.rs Outdated Show resolved Hide resolved
backend/src/gh.rs Outdated Show resolved Hide resolved
backend/src/gh.rs Outdated Show resolved Hide resolved
backend/src/gh.rs Outdated Show resolved Hide resolved
backend/src/gh.rs Outdated Show resolved Hide resolved
frontend/src/lib/components/topbar/PullRequest.svelte Outdated Show resolved Hide resolved
frontend/src/lib/components/topbar/PullRequest.svelte Outdated Show resolved Hide resolved
frontend/src/lib/components/topbar/PullRequest.svelte Outdated Show resolved Hide resolved
frontend/src/lib/components/topbar/PullRequest.svelte Outdated Show resolved Hide resolved
frontend/src/lib/components/topbar/PullRequest.svelte Outdated Show resolved Hide resolved
zleyyij
zleyyij requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@zleyyij zleyyij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure you're calling cargo fmt.

Other than that, just a few more itty tweaks and you should be good to go

backend/src/gh.rs Show resolved Hide resolved
backend/src/gh.rs Outdated Show resolved Hide resolved
backend/src/gh.rs Outdated Show resolved Hide resolved
backend/src/gh.rs Outdated Show resolved Hide resolved
backend/src/gh.rs Outdated Show resolved Hide resolved
backend/src/handlers_prelude/github_handlers.rs Outdated Show resolved Hide resolved
backend/src/main.rs Outdated Show resolved Hide resolved
backend/src/main.rs Outdated Show resolved Hide resolved
backend/src/main.rs Outdated Show resolved Hide resolved
backend/src/main.rs Show resolved Hide resolved
@zleyyij zleyyij merged commit 9418e6c into main Jan 14, 2025
3 checks passed
@zleyyij zleyyij deleted the github-client branch January 14, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zleyyij zleyyij zleyyij requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheKrol @zleyyij