Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random linebreaks, fixes #2 #3

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Remove random linebreaks, fixes #2 #3

merged 3 commits into from
Nov 11, 2019

Conversation

jeroen
Copy link
Member

@jeroen jeroen commented Oct 27, 2019

I think this is the simplest solution. I don't think it's worth it introducing options just for this, because this requires changing all the function signatures.

@gaborcsardi
Copy link
Contributor

TBH this seems a bit harsh, we might have fields where newlines are significant... strictly speaking it is already significant in fields that have R code, e.g. Authors@R. Not that this happens a lot, but why not just remove from the dependency fields?

@jeroen
Copy link
Member Author

jeroen commented Nov 11, 2019

That's fine by me as well. In my experience, the whitespace are mostly meaningless dcf artifacts, so for me it's safest to strip them to prevent database mismatches due to random whitespace.

But if you like to keep only strip them for selected fields, that's fine too. The most important case is the depends fields, where the current behavior is really a bug.

@gaborcsardi
Copy link
Contributor

Thanks!

@gaborcsardi gaborcsardi merged commit 5fdd7a2 into r-hub:master Nov 11, 2019
@jeroen
Copy link
Member Author

jeroen commented Nov 11, 2019

I was just pushing some tests! :D

@gaborcsardi
Copy link
Contributor

OK, I'll merge them manually.

@jeroen jeroen deleted the whitespace branch November 11, 2019 13:32
@gaborcsardi
Copy link
Contributor

Except you deleted the branch....

@gaborcsardi
Copy link
Contributor

Oh, they were included...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants