-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message for scope #1176
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 46 46
Lines 2655 2656 +1
=======================================
+ Hits 2447 2448 +1
Misses 208 208 ☔ View full report in Codecov by Sentry. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if dbaa169 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just minor changes...
Thanks for your suggestion, I applied them + a couple extra things here and there!
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if dbaa169 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @olivroy!
I think this can be merged once Lorenz also green-lights it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @olivroy. You can merge.
Also fixing some errors I introduced. When linking only to a help page, one should use topic, not help.
Also, I was wondering if it was possible to run styler, but only for quotes, i.e. changing
''
to""
?