Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colored output #1187

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Add colored output #1187

merged 2 commits into from
Mar 27, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Mar 27, 2024

Add minimal colored output to log

Chose color for consistency with cli theme

(would work well with hyperlinks #1186 )
image

Before, was all black

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (634dce1) to head (b34a4e0).

❗ Current head b34a4e0 differs from pull request most recent head 2e00803. Consider uploading reports for the commit 2e00803 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
+ Coverage   92.16%   92.18%   +0.01%     
==========================================
  Files          46       46              
  Lines        2654     2660       +6     
==========================================
+ Hits         2446     2452       +6     
  Misses        208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 634dce1 is merged into main:

  •   :ballot_box_with_check:cache_applying: 150ms -> 151ms [-3.21%, +3.73%]
  •   :ballot_box_with_check:cache_recording: 514ms -> 515ms [-0.43%, +0.85%]
  •   :ballot_box_with_check:without_cache: 981ms -> 979ms [-0.56%, +0.15%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@IndrajeetPatil IndrajeetPatil merged commit 208d9c7 into r-lib:main Mar 27, 2024
17 checks passed
@olivroy olivroy deleted the color branch March 27, 2024 19:33
@olivroy
Copy link
Contributor Author

olivroy commented Mar 27, 2024

Showing on the website https://styler.r-lib.org/dev/articles/styler.html#dry-mode!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants