fix Is the CString need to be freed? #10 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! So much cleaner. |
|
Thanks! Let me clarify. Does this mean the answer to my question "Is the CString need to be freed?" is "No"? |
I was worried about the validity of the returned pointer. Now that I'm looking at the r-source, I'm starting to worry, that yes, one has to free the resulting CString after the SEXP is created. |
|
Yeah, obviously, it's not what R can free because it's not allocated by R. So, hellorust decided to let it leak instead of worrying about it, right? I think it's also reasonable. |
|
I'll make another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
We have been up and down, and everywhere with this issue.
This PR contains how it really ought to be done. Note that the documentation for
std::mem::forgeteven recommends this approach.