Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI + fix roxygen2 warnings + fix anchored links #497

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Dec 17, 2024

  • Update github actions to use standard ones
  • Update roxygen2 and address deprecation warnings
  • Add anchor links
  • Use pkgdown 5 to add a search bar
  • Use roxygen markdown syntax.
  • Rebuild data with tools::resaveRdaFiles('data') as a R CMD CHECK warning occured.
  • Remove example using the albersusa package since it is archived and depends on maptools and rgdal.

The coverage action will likely fail when you merge to main. See r-lib/actions#834

I have trouble using devtools::load_all(). Do you have a tip to use it or you use a different strategy?

@olivroy olivroy marked this pull request as ready for review December 17, 2024 16:40
@tim-salabim
Copy link
Member

Thanks! This is great! Am I correct that we can get rid of the tic stuff then?

I have trouble using devtools::load_all(). Do you have a tip to use it or you use a different strategy?

I usually just use the keyboard shortcut to build and reload in RStudio. Never used devtools::load_all()

@olivroy
Copy link
Contributor Author

olivroy commented Dec 18, 2024

Indeed. I deleted tic.R and .github/workflows/tic.yaml

@olivroy olivroy changed the title Update CI + fix roxygen2 warnings Update CI + fix roxygen2 warnings + fix anchored links Dec 18, 2024
@tim-salabim tim-salabim merged commit 1c8bc11 into r-spatial:master Dec 20, 2024
7 checks passed
@olivroy olivroy deleted the ci branch December 20, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants