Merge pull request #12725 from rabbitmq/mergify/bp/v4.0.x/pr-12720

Grafana Dashboards: Fix Query Errors and Improve Instance Filtering in Erlang Distribution and BEAM Dashboards (backport #12720)
rabbitmq · Nov 14, 2024 · 2c0725f · 2c0725f
2 parents b9669ca + 3c8db6f
commit 2c0725f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-BEAM.json b/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-BEAM.json
@@ -140,7 +140,7 @@
           },
           "disableTextWrap": false,
           "editorMode": "builder",
-          "expr": "erlang_vm_statistics_run_queues_length",
+          "expr": "erlang_vm_statistics_run_queues_length{instance=\"$node\"}",
           "fullMetaSearch": false,
           "includeNullMetadata": true,
           "instant": false,
@@ -156,7 +156,7 @@
           },
           "disableTextWrap": false,
           "editorMode": "builder",
-          "expr": "erlang_vm_statistics_dirty_io_run_queue_length",
+          "expr": "erlang_vm_statistics_dirty_io_run_queue_length{instance=\"$node\"}",
           "fullMetaSearch": false,
           "hide": false,
           "includeNullMetadata": true,
@@ -173,7 +173,7 @@
           },
           "disableTextWrap": false,
           "editorMode": "builder",
-          "expr": "erlang_vm_statistics_dirty_cpu_run_queue_length",
+          "expr": "erlang_vm_statistics_dirty_cpu_run_queue_length{instance=\"$node\"}",
           "fullMetaSearch": false,
           "hide": false,
           "includeNullMetadata": true,
@@ -1165,6 +1165,20 @@
   ],
   "templating": {
     "list": [
+      {
+        "current": {},
+        "hide": 2,
+        "includeAll": false,
+        "label": "datasource",
+        "multi": false,
+        "name": "DS_PROMETHEUS",
+        "options": [],
+        "query": "prometheus",
+        "refresh": 1,
+        "regex": "",
+        "skipUrlSync": false,
+        "type": "datasource"
+      },
       {
         "current": {},
         "datasource": {

diff --git a/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-Distribution.json b/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-Distribution.json
@@ -542,10 +542,10 @@
           "displayType": "Regular",
           "displayValueWithAlias": "Never",
           "editorMode": "code",
-          "expr": "erlang_vm_dist_node_state{peer!~\"rabbitmqcli.*\"} * on(rabbitmq_instance, job) group_left(rabbitmq_cluster) rabbitmq_identity_info{rabbitmq_cluster=\"$rabbitmq_cluster\", namespace=\"$namespace\"}",
+          "expr": "erlang_vm_dist_node_state{peer!~\"rabbitmqcli.*\"} * on(instance, job) group_left(rabbitmq_cluster, rabbitmq_node) rabbitmq_identity_info{rabbitmq_cluster=\"$rabbitmq_cluster\", namespace=\"$namespace\"}",
           "format": "time_series",
           "intervalFactor": 1,
-          "legendFormat": "{{rabbitmq_instance}} -> {{ peer }}",
+          "legendFormat": "{{rabbitmq_node}} -> {{ peer }}",
           "range": true,
           "refId": "A",
           "units": "none",
@@ -2902,7 +2902,7 @@
         "showExtraInfo": false,
         "showItems": false
       },
-      "type": "flant-statusmap-panel",
+      "type": "status-history",
       "useMax": true,
       "usingPagination": false,
       "xAxis": {