Bump Khepri to 0.17.0 #12753
Draft
Bump Khepri to 0.17.0 #12753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
3 times, most recently
from
6d289fe to
cc6185d
Compare
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
6 times, most recently
from
5cb0a79 to
42f571a
Compare
dumbbell
reviewed
Dec 16, 2024
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
3 times, most recently
from
17e7652 to
d4c49f2
Compare
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
3 times, most recently
from
8caf8c0 to
8efd8ca
Compare
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
from
8efd8ca to
3b09f4c
Compare
|
Thank you for updating the branch! I’m working on updating Ra in Khepri but there are small changes of behaviors that cause test flakes. I fixed one of them (Ra can reture |
|
I fixed the bug in Do you think we can update Khepri in RabbitMQ now? Perhaps we should focus on that and release Khepri 0.17.0 this week. |
`locally_known_members/1` and `locally_known_node/1` were replaced with `members/2` and `nodes/2` with `favor` set to `low_latency` - this matches the interface for queries in Khepri.
All callers of `khepri_adv` and `khepri_tx_adv` need updates to handle the now consistent return type of `khepri:node_props_map()` in Khepri 0.17. We don't need any compatibility code to handle "either the old return type or the new return type" because the translation is done entirely in the "client side" code in Khepri - meaning that the return value from the Ra server is the same but it is translated differently by the functions in `khepri_adv` and `khepri_tx_adv`.
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
from
3b09f4c to
1b8eec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready to be merged yet, Khepri 0.17.0 hasn't yet been released. (And we want to make more changes before then anyways.)
This PR handles the breaking changes in Khepri 0.17.0.