Remove deprecated/unused/old startup checks #13069
Open
+3
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msg_store_io_batch_size is no longer used msg_store_credit_disc_bound appears to be used in the code, but I don't see any impact of that value on the performance. It should be properly investigated and either removed completely or fixed, because there's hardly any point in warning about the values configured (plus, this settings is hopefully almost never used anyway)
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msg_store_io_batch_size- this setting is no longer used (I also made it explicit in rabbit_msg_storemsg_store_credit_disc_bound- this setting is technically still checked in the code but I don't see any difference in performance, regardless of how I set it (even values such as{1, 1}work perfectly fine). We should take a closer look and probably just completely remove this know. However, since credit flow is tricky and maybe in some cases it has some impact, I left the usage as is, but since the validation was intertwined withmsg_store_io_batch_sizeand it's not clear what values we could even recommend - I just remove all validation.I've also removed
msg_store_credit_disc_boundthe docs, since I don't think people should worry about it at all:rabbitmq/rabbitmq-website@320071d