-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialyzer warnings rabbit v3.11.x #7024
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default queue type logic didn't apply when import was done for a single vhost. Exported definitions for a single vhost don't contain `vhost` key, and anyway it's better to use the actual vhost name that will be used for queue declaration. And just in case, `vhost` is now stripped from all exported items for a single vhost (it was still present in `parameters` and `policies`) - on import it was ignored, but it could have been a source of the bug similar to the one with the default queue type. (cherry picked from commit 4bfe352) # Conflicts: # deps/rabbit/src/rabbit_definitions.erl
Fix default queue type handling for single vhost imports (backport #6599)
`rabbit_definitions:apply_defs/5` contains a bug where it was trying to import bindings too early (https://github.com/rabbitmq/rabbitmq-server/blob/aec3dcbf37ac9f6cecf9f4c6bde7a49c4f045857/deps/rabbit/src/rabbit_definitions.erl#L480). `apply_defs/4` imports exchanges at exactly the same place. Turns out `apply_defs/5` is almost an verbatim copy of `apply_defs/4`, just with custom error handling - and it isn't being used anywhere in the source code. Also removes related unused exports. (cherry picked from commit aa0104c) # Conflicts: # deps/rabbit/src/rabbit_definitions.erl
Remove unused rabbit_definitions:apply_defs/5 (backport #6638)
(cherry picked from commit 20b2352) # Conflicts: # BUILD.bazel
Improve error output of `bazel run test-logs` (backport #6646)
(cherry picked from commit 9d8bb17)
(cherry picked from commit ba71c2a)
(cherry picked from commit b8ade09)
Also update with SHA512 so that the download and install via `mix archive.install` works. Related to: https://groups.google.com/g/rabbitmq-users/c/mSJMjyE20Nk (cherry picked from commit cedf909)
Update mix_task_archve_deps to 1.0.0 (backport #6652)
(cherry picked from commit 3d38483)
(cherry picked from commit 8b96b4e)
Bump Ra to 2.4.5 (backport #6662)
(cherry picked from commit cc28dba)
Update 3.10.13 release notes (backport #6665)
Custom exchange types can use the direct exchange as a proxy for routing. However, custom exchange types should continue to use "direct exchange routing v1" because their bindings are not inserted into the new routing table `rabbit_index_route`. This commits avoids changing the custom exchange types to call `rabbit_router:match_routing_key/2` directly as done in rabbitmq/rabbitmq-delayed-message-exchange#200 and rabbitmq/rabbitmq-lvc-exchange#32 because other exchange types are out there (as we learnt in #4606 (comment)) which also need to continue to use v1. So, the cleaner approach is to only use direct exchange routing v2 if 1. the feature flag 'direct_exchange_routing_v2' is enabled, and 2. the source exchange is of type 'direct' (cherry picked from commit a25eeb0)
Use direct exchange routing v1 for custom exchange types (backport #6658)
Does not require sending auth as a query parameter Ref: https://vmware.slack.com/archives/C0RDGG81Z/p1669827808015729 (cherry picked from commit a193f45)
Use more modern method to download definitions (backport #6674)
it did not match MODULE.bazel as it should
(cherry picked from commit d78b8b3) # Conflicts: # .github/workflows/update-otp-patches.yaml
(cherry picked from commit 04de0c7) # Conflicts: # deps/rabbitmq_peer_discovery_common/src/rabbit_peer_discovery_httpc.erl
Adopt OTP 25.2 (backport #6681)
Fix the cross-workflow reference to the oci workflow (cherry picked from commit 40a3cac)
Update rabbitmq_peer_discovery_aws.yaml (backport #6982)
Update rabbitmq_peer_discovery_aws.yaml (backport #6985)
This allows us to stop ignorning undefined callback warnings When mix compiles rabbitmqctl, it produces a 'consolidated' directory alongside the 'ebin' dir. Some of the modules in consolidated are intended to be used instead of those provided by elixir. We now handle the conflicts properly in the bazel build. (cherry picked from commit b84e746)
(cherry picked from commit 08d641a)
(cherry picked from commit 057f776)
(cherry picked from commit 3b2513e)
Rework elixir dialyze (backport #6919)
Search for `Error: Cannot find module 'node:events'` in internet suggests using at least node 16.6. (cherry picked from commit 6517c7f)
(cherry picked from commit 183a260) # Conflicts: # deps/rabbitmq_peer_discovery_consul/src/rabbit_peer_discovery_consul.erl # deps/rabbitmq_peer_discovery_etcd/src/rabbitmq_peer_discovery_etcd_v3_client.erl # deps/rabbitmq_peer_discovery_k8s/src/rabbitmq_peer_discovery_k8s_node_monitor.erl
(cherry picked from commit 684d960)
…sword (cherry picked from commit 67bc94e)
(cherry picked from commit 7fecfcd)
(cherry picked from commit 9735534)
Update the image reference in the AWS integration suite (backport #7016)
Cherry-pick of 7c0f040
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtual_host_metadata
feature flagsuser_limits
feature flagsmaintenance_mode_status
feature flagsstream_queue
in theenable_feature_flag
examplequorum_queue
feature flagsmaster
by adjusting indentationbadmatch
by taking edge case into accountbazel test //... ...
advanced.config
file, or manually in runtime.x-queue-type
intoarguments
on a queue when it is declared.:0:unknown_type Unknown type: :ssl.ssl_option/0.
.exrc
fileconnection.(un)blocked
messages from dest brokerrun_callback()
bazel run rabbitmq-streams
//:test-logs
and//:test-node-data
/metrics/detailed
endpoint to website.enable_callback()
docerpc:call/5
to properly catch exceptionsamqp_client
is_serving/{0,1}
functionalias
totest_suite
in deps/rabbitmq_cli/BUILD.bazelrabbit
rabbit