Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rabbit_password to rabbit_common #7429

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Move rabbit_password to rabbit_common #7429

merged 2 commits into from
Feb 26, 2023

Conversation

lukebakken
Copy link
Collaborator

@lukebakken
Move rabbit_password to rabbit_common
d9d6e1b 
This allows `rabbitmqctl hash_password` to run without having RabbitMQ up.

Follow-up to:
* #5957
* #7003
@lukebakken lukebakken self-assigned this Feb 25, 2023
@mergify mergify bot added the bazel label Feb 25, 2023
@lukebakken lukebakken mentioned this pull request Feb 25, 2023
Closed
@lukebakken lukebakken marked this pull request as ready for review February 25, 2023 20:17
@lukebakken
Copy link
Collaborator Author

@michaelklishin I'm not sure why rabbit_mgmt_only_http_SUITE failed in GHA, it passes locally 🤷‍♂️

@michaelklishin michaelklishin merged commit 1905995 into main Feb 26, 2023
@michaelklishin michaelklishin deleted the rabbitmq-server-5957-followup branch February 26, 2023 09:47
@mergify mergify bot mentioned this pull request Feb 26, 2023
Merged
michaelklishin added a commit that referenced this pull request Feb 26, 2023
@michaelklishin
Merge pull request #7434 from rabbitmq/mergify/bp/v3.12.x/pr-7429
7912478 
Move rabbit_password to rabbit_common (backport #7429)
@michaelklishin michaelklishin added this to the 3.11.10 milestone Feb 26, 2023
michaelklishin added a commit that referenced this pull request Feb 26, 2023
@michaelklishin
Merge pull request #7435 from rabbitmq/mergify/bp/v3.11.x/pr-7434
f709116 
Move rabbit_password to rabbit_common (backport #7429) (backport #7434)
michaelklishin added a commit that referenced this pull request Mar 28, 2023
@michaelklishin
Closes #7750
9e25979 
Adds a missing Elixir import which was (likely unintentionally)
removed in #7435 (#7429).
@michaelklishin michaelklishin mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

Assignees

@lukebakken lukebakken

Labels
backport-v3.11.x backport-v3.12.x bazel
Projects
None yet
Milestone
3.11.10
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebakken @michaelklishin