Restore non-cloud support #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can't and shouldn't be merged in its current state, it needs love. I'm opening the issue as a pull so the branch can't be accidentally deleted. Depends on #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the v1.0.0 refactor non-cloud support was removed to keep the scope to something resonable. This is the code that was removed, which needs to be completed before it can be re-added. It currently fails tests as the turbolift package doesn't install all the python modules required, requiring modules to be pip installed before turbolift will work. Having Chef pip install modules seems like a risk due to installing code from outside the package manager and potential issues with customer Python modules.