chore: Update ansible-lint and fix low hanging fruit (#12)

radiorabe · Dec 19, 2024 · 6ac21c4 · 6ac21c4
1 parent cbe5e09
commit 6ac21c4
Show file tree

Hide file tree

Showing 9 changed files with 24 additions and 6 deletions.
diff --git a/.ansible-lint-ignore b/.ansible-lint-ignore
@@ -0,0 +1,4 @@
+# This file contains ignores rule violations for ansible-lint
+
+# We should start writing changelogs at some point
+galaxy.yml galaxy[no-changelog]
diff --git a/.ansible-lint.yml b/.ansible-lint.yml
@@ -0,0 +1,8 @@
+---
+exclude_paths:
+  - .github/
+  - venv/
+write_list:
+  - all
+warn_list:
+  - meta-runtime[unsupported-version]
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -7,6 +7,6 @@ on:
 
 jobs:
   call-workflow:
-    uses: radiorabe/actions/.github/workflows/release-ansible-collection.yaml@v0.24.0
+    uses: radiorabe/actions/.github/workflows/release-ansible-collection.yaml@v0.26.0
     secrets:
       GALAXY_API_KEY: ${{ secrets.GALAXY_API_KEY }}
diff --git a/.github/workflows/semantic-release.yaml b/.github/workflows/semantic-release.yaml
@@ -7,6 +7,6 @@ on:
 
 jobs:
   call-workflow:
-    uses: radiorabe/actions/.github/workflows/semantic-release.yaml@v0.24.0
+    uses: radiorabe/actions/.github/workflows/semantic-release.yaml@v0.26.0
     secrets:
       RABE_ITREAKTION_GITHUB_TOKEN: ${{ secrets.RABE_ITREAKTION_GITHUB_TOKEN }}
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -7,4 +7,4 @@ on:
 
 jobs:
   call-workflow:
-    uses: radiorabe/actions/.github/workflows/test-ansible-collection.yaml@v0.24.0
+    uses: radiorabe/actions/.github/workflows/test-ansible-collection.yaml@v0.26.0
diff --git a/galaxy.yml b/galaxy.yml
@@ -1,3 +1,4 @@
+---
 namespace: radiorabe
 name: certbot
 version: 0.0.0
@@ -7,6 +8,7 @@ authors:
 description: Ansible collection that installs certbot for issuing letsencrypt certificates and pushing them to remote host.
 license_file: LICENSE
 tags:
+  - application
   - radiorabe
   - foreman
   - letsencrypt

diff --git a/meta/runtime.yml b/meta/runtime.yml
@@ -1 +1,2 @@
-requires_ansible: ">=2.11,<2.17"
+---
+requires_ansible: ">=2.14.0"
diff --git a/playbook.yml b/playbook.yml
@@ -1,3 +1,5 @@
-- hosts: all
+---
+- name: Run certbot role
+  hosts: all
   roles:
     - role: certbot
diff --git a/roles/certbot/meta/main.yml b/roles/certbot/meta/main.yml
@@ -1,9 +1,10 @@
+---
 galaxy_info:
   author: RaBe IT-Reaktion
   description: Install certbot, configure certificate renewal and deploy certificates to another host.
   issue_tracker_url: https://github.com/radiorabe/ansible-collection-certbot/issues
   license: AGPL-3.0-only
-  min_ansible_version: '2.9'
+  min_ansible_version: "2.14"
   platforms:
     - name: EL
       versions: