Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use lineinfile instead of sed #6

Merged
merged 1 commit into from
Dec 18, 2024
Merged

chore: use lineinfile instead of sed #6

merged 1 commit into from
Dec 18, 2024

Conversation

hairmare
Copy link
Member

@hairmare hairmare commented Dec 16, 2024 •
edited
Loading

This gives us idempotency and also make it slightly more readable.

main change in the target sysconfig is this:

- DEPLOY_HOOK="--deploy-hook \"/usr/bin/sh /usr/local/libexec/cert_sync.sh\""
+ DEPLOY_HOOK="--deploy-hook /usr/local/libexec/cert_sync.sh"

@hairmare hairmare marked this pull request as ready for review December 16, 2024 18:39
@hairmare hairmare requested a review from smirta December 16, 2024 18:39
@hairmare hairmare force-pushed the refactor/no-triple-escapery branch from b75da11 to 0c7819c Compare December 16, 2024 20:36
@hairmare hairmare force-pushed the refactor/no-triple-escapery branch from 0c7819c to 34370b0 Compare December 18, 2024 11:26
@hairmare hairmare merged commit faeaf1f into main Dec 18, 2024
1 check passed
@hairmare hairmare deleted the refactor/no-triple-escapery branch December 18, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smirta smirta Awaiting requested review from smirta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hairmare