Add DaySelect event to Day, Week and Month Views #1910
Merged
+94
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akorchev
requested changes
Jan 16, 2025
akorchev
requested changes
Jan 20, 2025
|
Hi @akorchev I've sent in another commit to resolve these issues a few days ago. Is there something else I need to be doing to this PR to move it along? |
akorchev
reviewed
Jan 24, 2025
| @@ -125,6 +125,11 @@ | |||
| await Scheduler.SelectSlot(date, date.AddDays(1), AppointmentsInSlot(date, date.AddDays(1))); | |||
| } | |||
|
|
|||
| async Task OnDayClick(DateTime day) | |||
| { | |||
| await Scheduler.SelectDay(day, AppointmentsInSlot(day.Date, day.Date.AddHours(23).AddMinutes(59).AddSeconds(59))); | |||
There was a problem hiding this comment.
This still feels wrong. Why are you doing it like this?
There was a problem hiding this comment.
You're right. It's should be as simple as
await Scheduler.SelectDay(day, AppointmentsInSlot(day, day.AddDays(1)));
Is this better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the
MonthSelecton the various Year Views, this will raise aSelectDayevent on a click of the Day Header (Day and Week View) or the Day Number (Month View).Additional
Also in this PR, I had to change a line in the
OnKeyPressevent inDayView.razor.This was taking the
CurrentDate, which includes theStartTimeand setting the range toCurrentDate.AddDays(1). This resulted in (using defaultStartTimevalue) from 08:00 one day to to 08:00 the next day. All other range calculations are based on actual start of day to end of day.