Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong type Value on DataBoundFormComponent<T> #1924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pianomanjh
Copy link
Contributor

@pianomanjh pianomanjh commented Jan 24, 2025

This updates the Value property of DataBoundFormComponent<T> to be of type T, for more canonical use, consistency, and ease of extension.
We have several custom controls that benefit from inheriting from this component, to better fit in the Radzen ecosystem. Needing to cast T when binding in these scenarios causes various difficulties, and is unnecessary as much as I can tell.

This should not result in any breaking changes, as users who are already casting this value to T will simply no longer need to.

Please let me know if I'm missing something as to the need for Value to be object vs T.

@akorchev
Copy link
Collaborator

This is a breaking change as some components support multiple selection and single selection. The value could be either T or IEnumerable depending on selection mode. I don't think we can accept this pull request.

@pianomanjh
Copy link
Contributor Author

Can you share an example with me? I've tested this across the various multi/single select component demos. (ListBox/DropDown/DropDownDataGrid/etc)

@enchev
Copy link
Collaborator

enchev commented Jan 27, 2025

DataGrid CheckBoxList filtering by first column
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants