Don't crash peer reviews updater if cannot remove an answer from queue

[nygrenh]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for peer review queue operations to prevent unexpected interruptions during course instance processing.
  • Added logging for specific errors encountered during peer review queue management.

[coderabbitai]

Walkthrough

The pull request introduces improved error handling in the peer_review_updater.rs file for asynchronous function calls related to peer review queue management. The changes wrap critical operations in error handling blocks, specifically for removing entries from the queue and giving full points. When an error occurs during these operations, the code now logs the specific error details and continues processing, preventing the entire course instance processing from being interrupted by a single failure.

Changes

File	Change Summary
services/headless-lms/server/src/programs/peer_review_updater.rs	Added error handling for remove_from_queue_and_add_to_manual_review and remove_from_queue_and_give_full_points function calls using if let Err(err) = ... construct

Possibly related PRs

• Make peer review updater to handle answers that teacher has not reviewed in 3 months #1371: Modifications to logic for retrieving peer review entries, specifically focusing on teacher reviews

Suggested labels

headless-lms

Poem

🐰 In the realm of peer review's dance,
Errors once lurked without a glance,
Now wrapped in care, with logging bright,
Each queue entry finds its rightful might,
Robust and strong, the code now prances! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

services/headless-lms/server/src/programs/peer_review_updater.rs (1)

59-63: Consider adding exercise ID to error logs.

The error handling implementation effectively prevents crashes and provides good context. To further improve debugging, consider including the exercise ID in the error logs since it's available in the outer scope.

Apply this diff to enhance error logging:

 error!(
     peer_review_queue_entry = ?peer_review_queue_entry,
+    exercise_id = ?exercise.id,
     "Failed to remove entry from queue and add to manual review: {:?}",
     err
 );

 error!(
     peer_review_queue_entry = ?peer_review_queue_entry,
+    exercise_id = ?peer_review_queue_entry.exercise_id,
     "Failed to remove entry from queue and give full points: {:?}",
     err
 );

Also applies to: 89-93

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40facbd and afcf521.

📒 Files selected for processing (1)

• services/headless-lms/server/src/programs/peer_review_updater.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: build-and-deploy
• GitHub Check: build
• GitHub Check: cms
• GitHub Check: headless_lms