Merge Sort Tree #106
Merged
Merge Sort Tree #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KowerKoint
reviewed
Mar 13, 2024
cpp/merge-sort-tree.hpp
Outdated
| } | ||
| } | ||
|
|
||
| if (i < n) { |
cpp/merge-sort-tree.hpp
Outdated
| } | ||
| } | ||
|
|
||
| value_type _prod_section(int l, int r, std::optional<key_type> a, std::optional<key_type> b) const { |
There was a problem hiding this comment.
aもbもnullならeではなく総積を返してほしくないですか。
初期値を総積にしておいてbのほうもhas_value()で右側範囲の逆元をかけると良いと思います。
cpp/merge-sort-tree.hpp
Outdated
| int last1 = j2; | ||
| int last2 = h * sz + std::min(n, i + t * 2); | ||
| while (j1 != last1 or j2 != last2) { | ||
| if (j1 == last1) { |
There was a problem hiding this comment.
特別気にしないのでそのままでもいいですが、同じことが2回ずつ書いてあると写経でミスする可能性が大きくなるのでj1 == last || (j2 < last && cmp(key_data[j2], key_data[j1])などとすると簡潔そうです。
KowerKoint
reviewed
Mar 13, 2024
cpp/merge-sort-tree.hpp
Outdated
| /** | ||
| * @brief product value[i] s.t. a <= key[i] < b , i in [l, r) | ||
| */ | ||
| value_type prod(std::optional<int> l = std::nullopt, std::optional<int> r = std::nullopt, std::optional<key_type> a = std::nullopt, std::optional<key_type> b = std::nullopt) const { |
There was a problem hiding this comment.
セグ木にassertを入れたのでここでも入れると良さそうです。
|
指摘を反映しました。 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.