Remove unused code and convert some functions to lamdas/std::fun #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've wanted to remove everything in the rak include folder for years, so this is a good start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the code in functional.h should be able to be replaced by the C++11 constructs. This first PR is more just demonstration, removing unused functions and replacing a couple of the lesser-used ones to ensure a) these patterns are something you're good with and b) before the changes need to happen across a ton of different files. If you're good with the changes, I'd be happy to put all them in this PR, or create multiple medium-sized ones, etc, whatever you'd prefer.