Convert __sync* built-ins to std::atomic #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also convert thread_base to use std::mutex instead of pthread_mutex
Also remove unused TaskManager test files
rakshasa
reviewed
Dec 1, 2024
src/torrent/utils/thread_interrupt.h
Outdated
| @@ -37,6 +37,8 @@ | |||
| #ifndef LIBTORRENT_UTILS_THREAD_INTERRUPT_H | |||
| #define LIBTORRENT_UTILS_THREAD_INTERRUPT_H | |||
|
|
|||
| #include "config.h" | |||
There was a problem hiding this comment.
This should never be in a header file.
There was a problem hiding this comment.
I have no quarrel with that, but it throws off clang-tidy since it can't infer what lt_cacheline_aligned is.
|
Check fix/atomic-types before making any changes, as I've done some more extensive work on fixing things there. #266 |
|
I have no problem with this getting closed in favor of your work, otherwise I'll wait until it's merged into master and compare/contrast at that point. |
|
I'd rather do the conversion myself as they need careful consideration and there are some improvements I'd like to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect these changes mean that
lt_cacheline_alignedis no longer required for some of the objects, but left them alone since I wasn't 100% on that.Addresses #253
Notable changes:
thread_base::m_globalwas simply changed to use std::atomic/std::mutex, it couldn't be initialized as a protected static member outside of the class in C++14 due to not being able to guarantee copy elision for std::atomic's construction. C++17 fixes this, but in the meantime I broke it out into two separate members since we shouldn't strictly need tolt_cacheline_alignedthem together anymore.