Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid bind and unique_ptr #288

Merged
merged 7 commits into from
Jan 19, 2025
Merged

avoid bind and unique_ptr #288

merged 7 commits into from
Jan 19, 2025

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Jan 9, 2025

No description provided.

rakshasa
rakshasa reviewed Jan 10, 2025
View reviewed changes
src/manager.cc Outdated Show resolved Hide resolved
@neheb neheb force-pushed the bind branch 2 times, most recently from bcc58c6 to d8fca27 Compare January 10, 2025 17:40
rakshasa
rakshasa reviewed Jan 12, 2025
View reviewed changes
src/torrent/utils/log.cc Outdated Show resolved Hide resolved
@neheb neheb force-pushed the bind branch 2 times, most recently from 9cef9ce to 2792558 Compare January 12, 2025 17:44
@rakshasa
Copy link
Owner 

<default> rtorrent-dev: (master) rtorrent-docker>rdo batch tests/ci-default 
staging ci default tests
stage cleaned
stage initialized
networks/rt-global-seed
networks/rt-global-v4
networks/rt-global-v6
networks/rt-global-v4-isolate
networks/rt-global-v6-isolate
dns/rt-dns-global
trackers/rt-tracker-global
stage deploying
dns/rt-dns-global
trackers/rt-tracker-global
stage deployed
clients/rt-seed-global-v4
clients/rt-seed-global-v6
append to node rt-seed-global-v6:
network.prefer.ipv6.set = true
torrents/torrent-global
torrent/torrent-global/node/rt-seed-global-v4
torrent/torrent-global/node/rt-seed-global-v6
torrents/torrent-global-v4only
torrent/torrent-global-v4only/node/rt-seed-global-v4
torrent/torrent-global-v4only/node/rt-seed-global-v6
torrents/torrent-global-v6only
torrent/torrent-global-v6only/node/rt-seed-global-v4
torrent/torrent-global-v6only/node/rt-seed-global-v6
stage deploying
clients/rt-seed-global-v4
clients/rt-seed-global-v6
stage deployed
waiting done       hash_done:rt-seed-global-v4:torrent-global
waiting done       hash_done:rt-seed-global-v6:torrent-global
        failed     hash_done:rt-seed-global-v4:torrent-global 21s
        failed     hash_done:rt-seed-global-v6:torrent-global 21s
waiting done       seeding:rt-seed-global-v4:torrent-global
waiting done       seeding:rt-seed-global-v6:torrent-global
        failed     seeding:rt-seed-global-v4:torrent-global 21s
        failed     seeding:rt-seed-global-v6:torrent-global 21s

Something is failing.

@neheb
Copy link
Contributor Author

neheb commented Jan 13, 2025

Removed bind commit. Will revisit.

@neheb neheb force-pushed the bind branch 4 times, most recently from b19d27e to 0de2039 Compare January 14, 2025 03:44
@rakshasa
Copy link
Owner

You're breaking clang-tidy action, likely need to update .clang-format.

@neheb
Copy link
Contributor Author

neheb commented Jan 14, 2025

The reason it’s failing is only because I’m modifying the header file.

@rakshasa
Copy link
Owner

rakshasa commented Jan 15, 2025 •
edited
Loading

Don't expand the PR or I won't review it again, fix the issues so it can be merged and open a new one for new changes.

Preferably roll back the new commits from yesterday.

@neheb neheb force-pushed the bind branch 2 times, most recently from 5fe56cc to 31934b2 Compare January 17, 2025 20:21
@neheb
Copy link
Contributor Author

neheb commented Jan 17, 2025

Split off some commits to a different PR.

rakshasa
rakshasa reviewed Jan 18, 2025
View reviewed changes
src/data/chunk.cc Outdated Show resolved Hide resolved
rakshasa
rakshasa reviewed Jan 18, 2025
View reviewed changes
src/data/hash_queue.cc Outdated Show resolved Hide resolved
rakshasa
rakshasa reviewed Jan 18, 2025
View reviewed changes
src/data/hash_queue.h Outdated Show resolved Hide resolved
@neheb
convert find_if to any/none/all_of
00d15fa 
Can avoid the lambdas by using operator==.

Also converted some to for range loops where it made sense.

Signed-off-by: Rosen Penev <[email protected]>
neheb added 6 commits January 18, 2025 11:07
@neheb
clang-tidy: for range loop conversions
4559069 
Signed-off-by: Rosen Penev <[email protected]>
@neheb
replace pthreads with std::mutex
65f0de3 
Replaced sleep + while with cv.wait().

Signed-off-by: Rosen Penev <[email protected]>
@neheb
replace accumulate with transform_reduce
f8d3c41 
The latter is more flexible.

Signed-off-by: Rosen Penev <[email protected]>
@neheb
remove some bind
1d99540 
Not really needed here.

Signed-off-by: Rosen Penev <[email protected]>
@neheb
remove VLA
048b314 
Deprecated in C++17. Also cleaned up surrounding code.

Signed-off-by: Rosen Penev <[email protected]>
@neheb
fix wrong function type
00abfe4 
Signed-off-by: Rosen Penev <[email protected]>
@rakshasa rakshasa merged commit ee06bed into rakshasa:master Jan 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakshasa rakshasa rakshasa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neheb @rakshasa