Merge pull request #1406 from ranaroussi/dev

dev -> main

tests/ticker.py

@@ -682,6 +682,7 @@ def setUp(self):
         self.symbols += ["ESLT.TA", "BP.L", "GOOGL"]
         self.symbols.append("QCSTIX")  # good for testing, doesn't trade
         self.symbols += ["BTC-USD", "IWO", "VFINX", "^GSPC"]
+        self.symbols += ["SOKE.IS", "ADS.DE"]  # detected bugs
         self.tickers = [yf.Ticker(s, session=self.session) for s in self.symbols]
 
     def tearDown(self):
@@ -702,18 +703,20 @@ def test_fast_info(self):
         fast_info_keys = sorted(list(fast_info_keys))
 
         key_rename_map = {}
+        key_rename_map["currency"] = "currency"
+        key_rename_map["quote_type"] = "quoteType"
+        key_rename_map["timezone"] = "exchangeTimezoneName"
+
         key_rename_map["last_price"] = ["currentPrice", "regularMarketPrice"]
         key_rename_map["open"] = ["open", "regularMarketOpen"]
         key_rename_map["day_high"] = ["dayHigh", "regularMarketDayHigh"]
         key_rename_map["day_low"] = ["dayLow", "regularMarketDayLow"]
         key_rename_map["previous_close"] = ["previousClose"]
         key_rename_map["regular_market_previous_close"] = ["regularMarketPreviousClose"]
 
-        # preMarketPrice
-
         key_rename_map["fifty_day_average"] = "fiftyDayAverage"
         key_rename_map["two_hundred_day_average"] = "twoHundredDayAverage"
-        key_rename_map["year_change"] = "52WeekChange"
+        key_rename_map["year_change"] = ["52WeekChange", "fiftyTwoWeekChange"]
         key_rename_map["year_high"] = "fiftyTwoWeekHigh"
         key_rename_map["year_low"] = "fiftyTwoWeekLow"
 
@@ -722,23 +725,29 @@ def test_fast_info(self):
         key_rename_map["three_month_average_volume"] = "averageVolume"
 
         key_rename_map["market_cap"] = "marketCap"
-        key_rename_map["shares"] = "floatShares"
-        key_rename_map["timezone"] = "exchangeTimezoneName"
+        key_rename_map["shares"] = "sharesOutstanding"
 
-        approximate_keys = {"fifty_day_average", "ten_day_average_volume"}
-        approximate_keys.update({"market_cap"})
+        for k in list(key_rename_map.keys()):
+            if '_' in k:
+                key_rename_map[yf.utils.snake_case_2_camelCase(k)] = key_rename_map[k]
 
-        # bad_keys = []
+        # Note: share count items in info[] are bad. Sometimes the float > outstanding!
+        # So often fast_info["shares"] does not match. 
+        # Why isn't fast_info["shares"] wrong? Because using it to calculate market cap always correct.
         bad_keys = {"shares"}
 
         # Loose tolerance for averages, no idea why don't match info[]. Is info wrong?
         custom_tolerances = {}
+        custom_tolerances["year_change"] = 1.0
         # custom_tolerances["ten_day_average_volume"] = 1e-3
         custom_tolerances["ten_day_average_volume"] = 1e-1
         # custom_tolerances["three_month_average_volume"] = 1e-2
         custom_tolerances["three_month_average_volume"] = 5e-1
         custom_tolerances["fifty_day_average"] = 1e-2
         custom_tolerances["two_hundred_day_average"] = 1e-2
+        for k in list(custom_tolerances.keys()):
+            if '_' in k:
+                custom_tolerances[yf.utils.snake_case_2_camelCase(k)] = custom_tolerances[k]
 
         for k in fast_info_keys:
             if k in key_rename_map:
@@ -756,7 +765,6 @@ def test_fast_info(self):
                         continue
 
                     if k in bad_keys:
-                        # Doesn't match, investigate why
                         continue
 
                     if k in custom_tolerances:
@@ -768,15 +776,22 @@ def test_fast_info(self):
                     correct = ticker.info[m]
                     test = ticker.fast_info[k]
                     # print(f"Testing: symbol={ticker.ticker} m={m} k={k}: test={test} vs correct={correct}")
-                    if k == "market_cap" and ticker.fast_info["currency"] in ["GBp", "ILA"]:
+                    if k in ["market_cap","marketCap"] and ticker.fast_info["currency"] in ["GBp", "ILA"]:
                         # Adjust for currency to match Yahoo:
                         test *= 0.01
-                    if correct is None:
-                        self.assertTrue(test is None or (not np.isnan(test)), f"{k}: {test} must be None or real value because correct={correct}")
-                    elif isinstance(test, float) or isinstance(correct, int):
-                        self.assertTrue(np.isclose(test, correct, rtol=rtol), f"{k}: {test} != {correct}")
-                    else:
-                        self.assertEqual(test, correct, f"{k}: {test} != {correct}")
+                    try:
+                        if correct is None:
+                            self.assertTrue(test is None or (not np.isnan(test)), f"{k}: {test} must be None or real value because correct={correct}")
+                        elif isinstance(test, float) or isinstance(correct, int):
+                            self.assertTrue(np.isclose(test, correct, rtol=rtol), f"{ticker.ticker} {k}: {test} != {correct}")
+                        else:
+                            self.assertEqual(test, correct, f"{k}: {test} != {correct}")
+                    except:
+                        if k in ["regularMarketPreviousClose"] and ticker.ticker in ["ADS.DE"]:
+                            # Yahoo is wrong, is returning post-market close not regular
+                            continue
+                        else:
+                            raise