Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Market Docs #2250

Merged
merged 3 commits into from
Feb 1, 2025
Merged

Fix Market Docs #2250

merged 3 commits into from
Feb 1, 2025

Conversation

R5dan
Copy link
Contributor

@R5dan R5dan commented Jan 31, 2025

This pr is to main so that docs can be updated without a new version being needed

@R5dan
Copy link
Contributor Author

R5dan commented Jan 31, 2025

@ValueRaider is this what you want?

Comment on lines 17 to 19
Search Sample Code
------------------
The `Search` module, allows you to access search data in a Pythonic way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to change the text you copied from Search

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, thought I changes it all.

@ValueRaider
Copy link
Collaborator

ValueRaider commented Jan 31, 2025

Looks fine.

But rebase to dev branch #1084 Docs currently update off dev, need to check something with @ranaroussi before switching to main.

@ValueRaider ValueRaider changed the base branch from main to dev January 31, 2025 23:04
@ValueRaider ValueRaider merged commit 8e369a2 into ranaroussi:dev Feb 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants