Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several addons [GSoC] #40

Merged
merged 21 commits into from
Oct 29, 2022
Merged

Several addons [GSoC] #40

merged 21 commits into from
Oct 29, 2022

Conversation

drmenzelit
Copy link
Contributor

Hello @ranbuch ,
we took a weekend to rewrite the code in typescript and now here is the pull request like promised so your script benefits from the new features, too. We would like to ask you to review the code, thank you in advance.

The list of features are:

  • We fixed the demo (moved everything to the "site" folder)
  • List of improvements from GSoC student: Final evaluation feedback joomla-projects/gsoc22_accessibility-plugin-script#9
  • Made a11y accessible with keyboard
  • Users can change the speech velocity
  • Implement increase / decrease line height
  • Fixed the italic icons and corrected the emoji for underline links
  • Made text-to-speech-language and speech-to-text language change to the currently active language of the site. Default is en-US. If the language is not supported then tts will not be displayed.

Looking forward to your feedback

@ranbuch ranbuch merged commit a8ee626 into ranbuch:master Oct 29, 2022
@ranbuch
Copy link
Owner

ranbuch commented Oct 29, 2022

Thank you @drmenzelit

I've made some small changes but it's merged to master. The main issue is we cannot debug the package without rebuild it when running it on http://localhost:8080/site/ with npm start.

Also, I'm not sure you've added your improvements to the readme file and the index.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants