Remove dependency on rancher-machine module #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjura
force-pushed
the
main-findtenantid
branch
from
296e04b to
c97a523
Compare
Add FindTenantID and NewSubscriptionsClient functions. FindTenantID function is used to find the tenant ID for the subscription ID. It will send an unauthenticated request to the Azure Resource Manager endpoint to get the tenant ID from the WWW-Authenticate header. Signed-off-by: Michal Jura <[email protected]>
mjura
force-pushed
the
main-findtenantid
branch
from
c97a523 to
d71f5a4
Compare
| "time" | ||
|
|
||
| "github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2020-11-01/containerservice" | ||
| "github.com/Azure/azure-sdk-for-go/services/resources/mgmt/2019-11-01/subscriptions" |
There was a problem hiding this comment.
Could the version of the azure sdk be unified here? 2020-11-01 for both.
There was a problem hiding this comment.
Unfortunately this version doesn't exist, we are using already 2019-11-01 next is completely new Azure SDK and migration will be done in another card #287
Danil-Grigorev
approved these changes
Nov 27, 2023
furkatgofurov7
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have to drop
rancher-machinemodule dependency, because it was deprecated.Add FindTenantID and NewSubscriptionsClient functions.
FindTenantID function is used to find the tenant ID for the subscription ID. It will send an unauthenticated request to the Azure Resource Manager endpoint to get the tenant ID from the WWW-Authenticate header.
Which issue(s) this PR fixes
Issue ##214