Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump apidiff.yaml go version #360

Merged

Conversation

salasberryfin
Copy link
Contributor

What this PR does / why we need it:

For the last couple of days we've had API diff validation workflow failing on new PRs.

After some investigation, it looks like this matches joelanford/go-apidiff's new release. As we're using the latest version here, CI is failing because our workflow is configured to use Go 1.18 while this new API diff action requires >=1.19.

This PR updates the workflow's Go version to match the project's (Go 1.20).

Which issue(s) this PR fixes
Issue #359

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

@salasberryfin salasberryfin added the kind/chore Internal stuff label Jan 17, 2024
@salasberryfin salasberryfin requested a review from a team as a code owner January 17, 2024 10:36
@mjura mjura merged commit 55318fd into rancher:main Jan 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Internal stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants