[dev-v2.11] prometheus-federator 105.1.0-rc.1+up0.4.5-rc.1 #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
1 similar comment
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
mallardduck
force-pushed
the
update-promfed
branch
from
37d475a to
ea7852f
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
mallardduck
force-pushed
the
update-promfed
branch
from
ea7852f to
2804995
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
2 similar comments
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
Comment on lines
+7
to
+10
| - registry: ghcr.io | ||
| - repository: rancher/prometheus-federator/helm-project-operator | ||
| + registry: '' | ||
| + repository: '' |
There was a problem hiding this comment.
Could be looking at this wrong, but doesn't look right. We should be setting this (I think)
There was a problem hiding this comment.
I opted to set these as empty - as this completely will exclude this image from release artifacts (like rancher-image-origins.txt). Since we never want end-users touching this helps remove those remaining traces of them.
For end users, the values for this should only come from the main defaults in prometheus-federator/values.yaml or their specific values. Where as the origin helm-project-operator chart defaults to the ghcr.io container for HPO.
There was a problem hiding this comment.
Example: https://github.com/rancher/rancher/releases/tag/v2.10.1-alpha1
Grab rancher-images-origins.txt from the release and it will have the HPO image listed.
By removing these from values at rancher/charts repo it will prevent the HPO image from ending up in releases or security scans. However the PromFed images customers actually use will still be in both.
mallardduck
force-pushed
the
update-promfed
branch
from
e3ed15e to
a2deb6d
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
This was referenced Dec 13, 2024
joshmeranda
requested changes
Dec 13, 2024
packages/rancher-monitoring/prometheus-federator/generated-changes/patch/Chart.yaml.patch
Show resolved
Hide resolved
alexandreLamarre
approved these changes
Dec 16, 2024
joshmeranda
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title, this adds a new PromFed RC