Merge pull request #12171 from richard-cox/reactivity

Update model reactivety

shell/plugins/dashboard-store/mutations.js

@@ -46,15 +46,24 @@ function registerType(state, type) {
 }
 
 export function replace(existing, data) {
+  const existingPropertyMap = {};
+
   for ( const k of Object.keys(existing) ) {
     delete existing[k];
+    existingPropertyMap[k] = true;
   }
 
+  let newProperty = false;
+
   for ( const k of Object.keys(data) ) {
+    if (!newProperty && !existingPropertyMap[k]) {
+      newProperty = true;
+    }
+
     existing[k] = data[k];
   }
 
-  return existing;
+  return newProperty ? reactive(existing) : existing;
 }
 
 function replaceResource(existing, data, getters) {
@@ -125,7 +134,7 @@ export function load(state, {
       entry = replaceResource(entry, data, getters);
     } else {
       // There's no entry, make a new proxy
-      entry = classify(ctx, data);
+      entry = reactive(classify(ctx, data));
     }
   }
 
@@ -268,7 +277,7 @@ export function batchChanges(state, { ctx, batch }) {
         if (normalizedType === SCHEMA) {
           addSchemaIndexFields(resource);
         }
-        const classyResource = classify(ctx, resource);
+        const classyResource = reactive(classify(ctx, resource));
 
         if (index === undefined) {
           typeCache.list.push(classyResource);
@@ -396,6 +405,9 @@ export default {
     }
   },
 
+  /**
+   * Load the results of a request that used a selector (like label)
+   */
   loadSelector(state, {
     type, entries, ctx, selector, revision
   }) {
@@ -412,6 +424,9 @@ export default {
     cache.revision = revision || 0;
   },
 
+  /**
+   * Load the results of a request to fetch all resources or all resources in a namespace
+   */
   loadAll,
 
   /**
@@ -441,8 +456,14 @@ export default {
     });
   },
 
+  /**
+   * Load resources, but don't set `haveAll`
+   */
   loadAdd,
 
+  /**
+   * Load the results of a request for a page. Often used to exercise advanced filtering
+   */
   loadPage(state, {
     type,
     data,