Skip to content

Commit

Permalink
Update notificationBlockList
Browse files Browse the repository at this point in the history
Signed-off-by: Francesco Torchia <[email protected]>
  • Loading branch information
torchiaf committed Jan 15, 2025
1 parent 55afa4f commit 259974e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion shell/config/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export const DEFAULT_PERF_SETTING: PerfSettings = {
/**
* Show warnings in a notification if they're not in this block list
*/
notificationBlockList: ['299 - unknown field']
notificationBlockList: ['299 - unknown field', '299 - "unknown field']
}
},
serverPagination: {
Expand Down
4 changes: 2 additions & 2 deletions shell/plugins/steve/__tests__/header-warnings.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ describe('steve: header-warnings', () => {

function setupMocks(settings = {
separator: '299 - ',
notificationBlockList: ['299 - unknown field']
notificationBlockList: DEFAULT_PERF_SETTING.kubeAPI.warningHeader.notificationBlockList,
}) {
return {
dispatch: jest.fn(),
Expand Down Expand Up @@ -53,7 +53,7 @@ describe('steve: header-warnings', () => {
const createKey = 'growl.kubeApiHeaderWarning.titleCreate';
const podSecurity = '299 - would violate PodSecurity "restricted:latest": unrestricted capabilities (container "container-0" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (container "container-0" must not set securityContext.runAsNonRoot=false), seccompProfile (pod or container "container-0" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")';
const deprecated = "299 - i'm deprecated";
const validation = '299 - unknown field "spec.containers[0].__active"';
const validation = '299 - "unknown field "spec.containers[0].__active"';

describe('no warnings', () => {
it('put, no header warning', () => {
Expand Down

0 comments on commit 259974e

Please sign in to comment.