Skip to content

Commit

Permalink
modified GKE components to have an unique id
Browse files Browse the repository at this point in the history
Signed-off-by: Isabela Guimaraes <[email protected]>
  • Loading branch information
IsaSih committed Jan 15, 2025
1 parent 53d28f4 commit 80b137b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,12 @@ export default class ClusterManagerCreateGKEPagePo extends ClusterManagerCreateP
static getGkeZoneSelect() {
return new LabeledSelectPo('[data-testid="gke-zone-select"]');
}

getClusterName() {
return new LabeledInputPo('[data-testid="gke-cluster-name"]');
}

getClusterDescription() {
return new LabeledInputPo('[data-testid="gke-cluster-description"]');
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ describe('Deploy GKE cluster with default settings', { tags: ['@manager', '@admi
});

// Set the cluster name and description in the Create GKE Page
createGKEClusterPage.nameNsDescription().name().set(this.gkeClusterName);
createGKEClusterPage.getClusterName().set(this.gkeClusterName);
clusterDescription = `${ this.gkeClusterName }-description`;
createGKEClusterPage.nameNsDescription().description().set(clusterDescription);
createGKEClusterPage.getClusterDescription().set(clusterDescription);
});

// Create GKE Cluster and verify that the properties posted to the server match the expected settings
Expand Down
2 changes: 0 additions & 2 deletions pkg/gke/components/CruGKE.vue
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,6 @@ export default defineComponent({
>
<div
class="col span-6"
data-testid="name-ns-description-name"
>
<LabeledInput
:value="normanCluster.name"
Expand All @@ -713,7 +712,6 @@ export default defineComponent({
</div>
<div
class="col span-6"
data-testid="name-ns-description-description"
>
<LabeledInput
:value="normanCluster.description"
Expand Down

0 comments on commit 80b137b

Please sign in to comment.