Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml: >=2.2.2 #12090

Closed
Tracked by #9648
rak-phillip opened this issue Oct 1, 2024 · 4 comments · Fixed by #12103
Closed
Tracked by #9648

yaml: >=2.2.2 #12090

rak-phillip opened this issue Oct 1, 2024 · 4 comments · Fixed by #12103
Assignees
Labels
area/harvester QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@rak-phillip
Copy link
Member

No description provided.

@rak-phillip rak-phillip mentioned this issue Oct 1, 2024
9 tasks
@rak-phillip rak-phillip self-assigned this Oct 1, 2024
@rak-phillip rak-phillip added the area/vue3 Bugs and technical debts as outcome to the Vue3 migration label Oct 1, 2024
@rak-phillip rak-phillip added this to the v2.10.0 milestone Oct 1, 2024
@github-actions github-actions bot added QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this and removed area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Oct 1, 2024
@rak-phillip rak-phillip mentioned this issue Oct 2, 2024
7 tasks
@yonasberhe23
Copy link
Contributor

dependency bump touches Harvester, we should probably do smoke test to ensure nothing is broken there. Moving to To Test

@izaac
Copy link
Contributor

izaac commented Oct 30, 2024

@rak-phillip what would be the result in case it's broken on Harvester? It's a one off broken or working scenario? Or does it involve a more detailed validation.

If the former I think we can move this one to done, as there are other 2.10 Harvester issues pending validation already.

@rak-phillip
Copy link
Member Author

rak-phillip commented Oct 31, 2024

@izaac see this comment in the associated PR for more details

#12103 (review)

the YAML dependency is used to handle the User Data field as a yaml.

If it is broken for any reason, we can anticipate that one of the following might occur

  • data does not render for this field
  • data does render, but is not properly parsed as YAML
  • uncaught errors are printed to the console

@izaac izaac self-assigned this Nov 13, 2024
@izaac
Copy link
Contributor

izaac commented Nov 13, 2024

Validated on Rancher version: v2.10.0-alpha11
UI version: v2.10.0-alpha6
Harvester plugin version: 1.0.0
Harvester clusters versions: 1.4-head and 1.3.2 - (1.4 target is Rancher 2.10).

I was able to navigate without issues between the two imported Harvester clusters in the Virtualization Management.
I've provisioned a Virtual Machine too on each cluster and the User Data field were rendered properly in the UI showing the YAML.

@izaac izaac closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/harvester QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants